Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(121)

Issue 12431043: code review 12431043: odbc: add darwin target (uses unixODBC) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by brainman
Modified:
11 years, 8 months ago
Reviewers:
CC:
juztin
Visibility:
Public.

Description

odbc: add darwin target (uses unixODBC) Fixes issue 13

Patch Set 1 #

Patch Set 2 : diff -r 73cbd9ce014c https://code.google.com/p/odbc #

Patch Set 3 : diff -r dcbbd608914d https://code.google.com/p/odbc #

Patch Set 4 : diff -r dcbbd608914d https://code.google.com/p/odbc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M api/Makefile View 1 1 chunk +2 lines, -2 lines 0 comments Download
M api/api_unix.go View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M api/mksyscall_unix.pl View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M api/zapi_unix.go View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8
brainman
Hello brainman, I'd like you to review this change to https://code.google.com/p/odbc
11 years, 8 months ago (2013-10-15 06:01:46 UTC) #1
juztin
On 2013/10/15 06:01:46, brainman wrote: > Hello brainman, > > I'd like you to review ...
11 years, 8 months ago (2013-10-15 16:16:50 UTC) #2
brainman
*** Submitted as https://code.google.com/p/odbc/source/detail?r=1f170996324b *** odbc: add darwin target (uses unixODBC) Fixes issue 13 R=alex.brainman, ...
11 years, 8 months ago (2013-10-15 23:39:41 UTC) #3
brainman
Thank you, Justin. Now, that we can run on darwin, it would be good to ...
11 years, 8 months ago (2013-10-15 23:41:21 UTC) #4
juztin
Hey Alex, I've got our team updated with the new commit. Thanks! I'd be glad ...
11 years, 8 months ago (2013-10-16 00:35:36 UTC) #5
brainman
On 2013/10/16 00:35:36, juztin wrote: > > I'd be glad to write something up, lemme ...
11 years, 8 months ago (2013-10-16 01:00:02 UTC) #6
juztin
Hey Alex, Sorry, I meant to get this done last weekend. I've added the documentation ...
11 years, 8 months ago (2013-10-27 01:00:23 UTC) #7
brainman
11 years, 8 months ago (2013-10-27 07:33:15 UTC) #8
Message was sent while issue was closed.
On 2013/10/27 01:00:23, juztin wrote:
> 
> I've added the documentation for OS X. A guy I work with just got a new
> computer so I'll have him run through the documentation and make sure it
> all makes sense. ...

Excellent. Thank you very much. I have change main project page to include link
to your doco. Hopefully others should be able to follow your path on OS X. :-)

> I also plan on installing unixODBC/FreeTDS from source (without MacPorts)
> on one of my machines. When I get this done I'll add documentation as an
> alternate install process for OS X (people who don't have/want MacPorts).

Sounds good. If you wish.

Thanks again for your help.

Alex
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b