Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(518)

Issue 124280044: code review 124280044: dwarf: fix broken tests, due to name change in (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 3 months ago by nigeltao
Modified:
7 years, 3 months ago
Reviewers:
r
Visibility:
Public.

Description

dwarf: fix broken tests, due to name change in codereview.appspot.com/112270043 "ogle/server: provide type-aware printer for DWARF-typed objects"

Patch Set 1 #

Patch Set 2 : diff -r a875c179a54f https://code.google.com/p/ogle #

Patch Set 3 : diff -r a875c179a54f https://code.google.com/p/ogle #

Patch Set 4 : diff -r a875c179a54f https://code.google.com/p/ogle #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M debug/dwarf/frame_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M debug/dwarf/pclntab_test.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
nigeltao
Hello r@golang.org, I'd like you to review this change to https://code.google.com/p/ogle
7 years, 3 months ago (2014-08-18 03:18:09 UTC) #1
nigeltao
*** Submitted as https://code.google.com/p/ogle/source/detail?r=e08d92e2f8a1 *** dwarf: fix broken tests, due to name change in codereview.appspot.com/112270043 ...
7 years, 3 months ago (2014-08-18 03:18:56 UTC) #2
r
7 years, 3 months ago (2014-08-18 05:09:52 UTC) #3
Message was sent while issue was closed.
LGTM sorry
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b