Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(43)

Issue 124260043: code review 124260043: doc/compat1.html: link to go.sys (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by r
Modified:
10 years, 9 months ago
Reviewers:
minux
CC:
golang-codereviews, minux
Visibility:
Public.

Description

doc/compat1.html: link to go.sys You talked me into it. This and other links should be updated once the new import paths for the subrepos are established.

Patch Set 1 #

Total comments: 2

Patch Set 2 : diff -r 8f4e145adc9da707e9a5cf658bf933c52dc3bad5 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M doc/go1compat.html View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4
r
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
10 years, 9 months ago (2014-08-12 22:29:10 UTC) #1
minux
LGTM. https://codereview.appspot.com/124260043/diff/1/doc/go1compat.html File doc/go1compat.html (right): https://codereview.appspot.com/124260043/diff/1/doc/go1compat.html#newcode165 doc/go1compat.html:165: <a href="//code.google.com/p/go.sys">code.google.com/p/go.sys</a> subrepository. href="//godoc.org/code.google.com/p/go.sys" ? seems better than ...
10 years, 9 months ago (2014-08-12 22:39:42 UTC) #2
r
https://codereview.appspot.com/124260043/diff/1/doc/go1compat.html File doc/go1compat.html (right): https://codereview.appspot.com/124260043/diff/1/doc/go1compat.html#newcode165 doc/go1compat.html:165: <a href="//code.google.com/p/go.sys">code.google.com/p/go.sys</a> subrepository. On 2014/08/12 22:39:42, minux wrote: > ...
10 years, 9 months ago (2014-08-12 22:43:09 UTC) #3
r
10 years, 9 months ago (2014-08-12 22:43:25 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=c0962fae8bd0 ***

doc/compat1.html: link to go.sys
You talked me into it. This and other links should be updated
once the new import paths for the subrepos are established.

LGTM=minux
R=golang-codereviews, minux
CC=golang-codereviews
https://codereview.appspot.com/124260043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b