Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(283)

Issue 12420045: code review 12420045: crypto: include hash number in panic message. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years ago by agl1
Modified:
9 years ago
Reviewers:
rsc
CC:
golang-dev, rsc
Visibility:
Public.

Description

crypto: include hash number in panic message. In the event that code tries to use a hash function that isn't compiled in and panics, give the developer a fighting chance of figuring out which hash function it needed.

Patch Set 1 #

Patch Set 2 : diff -r adc2b4f10096 https://code.google.com/p/go/ #

Patch Set 3 : diff -r adc2b4f10096 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 6dee0694f35b https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/pkg/crypto/crypto.go View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 3
agl1
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
9 years ago (2013-08-05 15:20:15 UTC) #1
rsc
LGTM
9 years ago (2013-08-05 17:33:20 UTC) #2
agl1
9 years ago (2013-08-05 18:23:39 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=7c8d63925fa2 ***

crypto: include hash number in panic message.

In the event that code tries to use a hash function that isn't compiled
in and panics, give the developer a fighting chance of figuring out
which hash function it needed.

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/12420045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b