Issue 124130043: code review 124130043: compress/{gzip,zlib}: mention that Close flushes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 124130043: code review 124130043: compress/{gzip,zlib}: mention that Close flushes (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by adg

Modified:
11 years, 2 months ago

Reviewers:
rsc

CC:
r, rsc, golang-codereviews

Visibility:
Public.

Description

compress/{gzip,zlib}: mention that Close flushes Our other CloseFlushers (archive/tar, compress/flate) do mention this. The original change was accidentally submitted to the release branch: https://codereview.appspot.com/117430043/

Patch Set 1 #

Patch Set 2 : diff -r 3a2621a2e43b48f497d48c763fb5df88ffc415f1 https://code.google.com/p/go #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	src/pkg/compress/gzip/gzip.go	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	src/pkg/compress/zlib/writer.go	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adg

Hello r, rsc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

11 years, 2 months ago (2014-08-11 23:16:05 UTC) #1

adg

*** Submitted as https://code.google.com/p/go/source/detail?r=d02e86810ddb *** compress/{gzip,zlib}: mention that Close flushes Our other CloseFlushers (archive/tar, compress/flate) ...

11 years, 2 months ago (2014-08-11 23:27:53 UTC) #2

LGTM

Expand All Messages | Collapse All Messages