Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(77)

Issue 124130043: code review 124130043: compress/{gzip,zlib}: mention that Close flushes (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by adg
Modified:
11 years, 2 months ago
Reviewers:
rsc
CC:
r, rsc, golang-codereviews
Visibility:
Public.

Description

compress/{gzip,zlib}: mention that Close flushes Our other CloseFlushers (archive/tar, compress/flate) do mention this. The original change was accidentally submitted to the release branch: https://codereview.appspot.com/117430043/

Patch Set 1 #

Patch Set 2 : diff -r 3a2621a2e43b48f497d48c763fb5df88ffc415f1 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M src/pkg/compress/gzip/gzip.go View 1 chunk +2 lines, -1 line 0 comments Download
M src/pkg/compress/zlib/writer.go View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3
adg
Hello r, rsc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
11 years, 2 months ago (2014-08-11 23:16:05 UTC) #1
adg
*** Submitted as https://code.google.com/p/go/source/detail?r=d02e86810ddb *** compress/{gzip,zlib}: mention that Close flushes Our other CloseFlushers (archive/tar, compress/flate) ...
11 years, 2 months ago (2014-08-11 23:27:53 UTC) #2
rsc
11 years, 2 months ago (2014-08-11 23:56:29 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b