Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(165)

Issue 124115: Change representation of attribute names in client-side HTML schemas. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 6 months ago by MikeSamuel
Modified:
16 years, 6 months ago
Reviewers:
Jasvir
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

On the server, we use a::href style attribute names in schemas with two colons between element and attribute names so that we can allow prefixed names, e.g. html::xml:lang and svg:rect::id. But on the client, we use one colon, e.g. a:href. This is a semantics preserving change which brings our client side representation in sync with the server side one. Submitted @3788

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -36 lines) Patch
M src/com/google/caja/lang/css/CssPropertyPatterns.java View 7 chunks +14 lines, -16 lines 0 comments Download
M src/com/google/caja/lang/html/HtmlDefinitions.java View 1 chunk +1 line, -1 line 0 comments Download
M src/com/google/caja/plugin/bridal.js View 1 chunk +2 lines, -2 lines 0 comments Download
M src/com/google/caja/plugin/domita.js View 3 chunks +5 lines, -5 lines 0 comments Download
M src/com/google/caja/plugin/html-sanitizer.js View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/com/google/caja/plugin/domita_test_untrusted.html View 2 chunks +6 lines, -8 lines 2 comments Download
M tests/com/google/caja/plugin/html-sanitizer-test.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
MikeSamuel
16 years, 6 months ago (2009-10-05 19:46:01 UTC) #1
MikeSamuel
http://codereview.appspot.com/124115/diff/1/2 File tests/com/google/caja/plugin/domita_test_untrusted.html (left): http://codereview.appspot.com/124115/diff/1/2#oldcode643 Line 643: // running. This makes no sense since tests ...
16 years, 6 months ago (2009-10-05 19:48:42 UTC) #2
Jasvir
16 years, 6 months ago (2009-10-08 19:22:24 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b