Issue 12401043: code review 12401043: go.tools/go/types: Fix for broken IsAssignableTo.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12401043: code review 12401043: go.tools/go/types: Fix for broken IsAssignableTo. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by gri

Modified:
12 years, 2 months ago

Reviewers:
r

CC:
adonovan, golang-dev

Visibility:
Public.

Description

go.tools/go/types: Fix for broken IsAssignableTo. Was broken by CL 12378043. - factored out some error checking code - adjusted error positions

Patch Set 1 #

Patch Set 2 : diff -r abb36107ee00 https://code.google.com/p/go.tools #

Patch Set 3 : diff -r c41ae491ae83 https://code.google.com/p/go.tools #

Patch Set 4 : diff -r c41ae491ae83 https://code.google.com/p/go.tools #

Patch Set 5 : diff -r c41ae491ae83 https://code.google.com/p/go.tools #

Patch Set 6 : diff -r c41ae491ae83 https://code.google.com/p/go.tools #

Patch Set 7 : diff -r f0372997088c https://code.google.com/p/go.tools #

Patch Set 8 : diff -r f0372997088c https://code.google.com/p/go.tools #

Patch Set 9 : diff -r f0372997088c https://code.google.com/p/go.tools #

Patch Set 10 : diff -r f0372997088c https://code.google.com/p/go.tools #

Patch Set 11 : diff -r f0372997088c https://code.google.com/p/go.tools #

Patch Set 12 : diff -r f0372997088c https://code.google.com/p/go.tools #

Patch Set 13 : diff -r f0372997088c https://code.google.com/p/go.tools #

Patch Set 14 : diff -r f0372997088c https://code.google.com/p/go.tools #

Total comments: 1

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -55 lines)			Patch
M	go/types/expr.go	View	1 2 3 4 5 6 7 8 9	3 chunks	+21 lines, -20 lines	0 comments	Download
M	go/types/lookup.go	View	1 2 3 4 5 6 7 8 9 10	1 chunk	+18 lines, -8 lines	1 comment	Download
M	go/types/operand.go	View	1 2 3 4 5 6 7 8 9	1 chunk	+1 line, -1 line	0 comments	Download
M	go/types/stmt.go	View	1 2 3 4 5 6	3 chunks	+9 lines, -18 lines	0 comments	Download
M	go/types/testdata/conversions.src	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	go/types/testdata/expr3.src	View	1 2 3 4 5 6	1 chunk	+4 lines, -4 lines	0 comments	Download
M	ssa/interp/ops.go	View	1 2 3 4 5 6 7 8 9	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

gri

Hello r@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools

12 years, 3 months ago (2013-08-03 06:38:52 UTC) #1

gri

Hello r@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

12 years, 3 months ago (2013-08-05 20:06:27 UTC) #2

gri

Hello adonovan@google.com (cc: golang-dev@googlegroups.com), Please take another look.

12 years, 3 months ago (2013-08-05 20:24:38 UTC) #3

gri

*** Submitted as https://code.google.com/p/go/source/detail?r=170c5db3cb30&repo=tools *** go.tools/go/types: Fix for broken IsAssignableTo. Was broken by CL 12378043. ...

12 years, 3 months ago (2013-08-05 20:54:25 UTC) #4

12 years, 2 months ago (2013-08-05 22:15:38 UTC) #5

Message was sent while issue was closed.

LGTM

fix the typo in your next CL

https://codereview.appspot.com/12401043/diff/37001/go/types/lookup.go
File go/types/lookup.go (right):

https://codereview.appspot.com/12401043/diff/37001/go/types/lookup.go#newcode239
go/types/lookup.go:239: // TODO(gri) Consider using methods sets here. Might be
more efficient.
s/methods/method/

Expand All Messages | Collapse All Messages