Issue 123970043: code review 123970043: debug/pe/testdata: make sure gcc-amd64-mingw-exec has s...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 123970043: code review 123970043: debug/pe/testdata: make sure gcc-amd64-mingw-exec has s... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by brainman

Modified:
10 years, 9 months ago

Reviewers:
gobot, rsc

CC:
rsc, golang-codereviews

Visibility:
Public.

Description

debug/pe/testdata: make sure gcc-amd64-mingw-exec has symbols as per rsc request

Patch Set 1 #

Patch Set 2 : diff -r bb9f6c4f6cb330e6f9d5c717fc8e474635b7a71c https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r bb9f6c4f6cb330e6f9d5c717fc8e474635b7a71c https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r bb9f6c4f6cb330e6f9d5c717fc8e474635b7a71c https://go.googlecode.com/hg/ #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -12 lines)			Patch
	M	src/pkg/debug/pe/file_test.go	View	1	2 chunks	+19 lines, -12 lines	0 comments	Download
	M	src/pkg/debug/pe/testdata/gcc-amd64-mingw-exec	View	1	Binary file		0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

brainman

Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

10 years, 9 months ago (2014-08-08 04:59:58 UTC) #1

brainman

For the record, this is the command I have used: gcc -O2 -Wall -Werror -o ...

10 years, 9 months ago (2014-08-08 05:03:17 UTC) #2

brainman

*** Submitted as https://code.google.com/p/go/source/detail?r=4be843c55986 *** debug/pe/testdata: make sure gcc-amd64-mingw-exec has symbols as per rsc request ...

10 years, 9 months ago (2014-08-08 06:19:57 UTC) #4

gobot

10 years, 9 months ago (2014-08-08 08:13:49 UTC) #5

Message was sent while issue was closed.

This CL appears to have broken the plan9-386-cnielsen builder.
See http://build.golang.org/log/7eec1eb49a2a3f05ab22331ed06500f459e9738d

Expand All Messages | Collapse All Messages