Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1037)

Issue 12387043: code review 12387043: html/template: handle nils during indirection (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by josharian
Modified:
12 years, 4 months ago
Reviewers:
r
CC:
golang-dev, r
Visibility:
Public.

Description

html/template: handle nils during indirection Fixes issue 5982.

Patch Set 1 #

Patch Set 2 : diff -r 4a3d328fe8e9 https://code.google.com/p/go #

Patch Set 3 : diff -r 4a3d328fe8e9 https://code.google.com/p/go #

Total comments: 2

Patch Set 4 : diff -r 4a3d328fe8e9 https://code.google.com/p/go #

Patch Set 5 : diff -r 4a3d328fe8e9 https://code.google.com/p/go #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M src/pkg/html/template/content.go View 1 2 chunks +6 lines, -0 lines 0 comments Download
M src/pkg/html/template/content_test.go View 1 2 3 1 chunk +19 lines, -0 lines 1 comment Download

Messages

Total messages: 6
josharian
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
12 years, 4 months ago (2013-08-03 01:12:25 UTC) #1
r
https://codereview.appspot.com/12387043/diff/6001/src/pkg/html/template/content_test.go File src/pkg/html/template/content_test.go (right): https://codereview.appspot.com/12387043/diff/6001/src/pkg/html/template/content_test.go#newcode267 src/pkg/html/template/content_test.go:267: defer func() { you don't need to do this. ...
12 years, 4 months ago (2013-08-03 21:59:54 UTC) #2
josharian
Hello golang-dev@googlegroups.com, r@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 4 months ago (2013-08-03 22:33:43 UTC) #3
r
LGTM https://codereview.appspot.com/12387043/diff/16001/src/pkg/html/template/content_test.go File src/pkg/html/template/content_test.go (right): https://codereview.appspot.com/12387043/diff/16001/src/pkg/html/template/content_test.go#newcode265 src/pkg/html/template/content_test.go:265: tmpl := Must(New("TestEscapingNilNonemptyInterfaces").Parse("{{.E}}")) the name "x" would serve ...
12 years, 4 months ago (2013-08-03 22:38:08 UTC) #4
josharian
> you don't need to do this. if it panics, the test is broken and ...
12 years, 4 months ago (2013-08-03 22:39:43 UTC) #5
r
12 years, 4 months ago (2013-08-03 22:41:25 UTC) #6
*** Submitted as https://code.google.com/p/go/source/detail?r=d20b285974a4 ***

html/template: handle nils during indirection

Fixes issue 5982.

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/12387043

Committer: Rob Pike <r@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b