Issue 123870043: code review 123870043: cmd/go: download test dependencies of all named packages

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 123870043: code review 123870043: cmd/go: download test dependencies of all named packages (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by adg

Modified:
10 years, 9 months ago

Reviewers:
rsc

CC:
rsc, golang-codereviews

Visibility:
Public.

Description

cmd/go: download test dependencies of all named packages Fixes issue 8181.

Patch Set 2 : diff -r cf99a05f0fbc945aefe2acbf92a2d050ec58b6a1 https://code.google.com/p/go #

Patch Set 3 : diff -r cf99a05f0fbc945aefe2acbf92a2d050ec58b6a1 https://code.google.com/p/go #

Total comments: 1

Patch Set 4 : diff -r 3a3ad5bbd67ad42519af51b7b59a3fa9322aadc6 https://code.google.com/p/go #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -1 line)			Patch
	M	src/cmd/go/get.go	View		1 chunk	+3 lines, -1 line	0 comments	Download
	M	src/cmd/go/test.bash	View	1 2 3	1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

adg

Hello rsc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

10 years, 9 months ago (2014-08-07 08:02:34 UTC) #1

adg

I'd like to write a test for this but I'm not sure how, short of ...

10 years, 9 months ago (2014-08-07 08:03:29 UTC) #2

rsc

test.bash already assumes it can go get other things. creating a tiny repo with tests ...

10 years, 9 months ago (2014-08-07 12:35:44 UTC) #3

rsc

LGTM https://codereview.appspot.com/123870043/diff/40001/src/cmd/go/test.bash File src/cmd/go/test.bash (right): https://codereview.appspot.com/123870043/diff/40001/src/cmd/go/test.bash#newcode546 src/cmd/go/test.bash:546: TEST go get -t code.google.com/p/go-get-issue-8181/{a,b} quote the final ...

10 years, 9 months ago (2014-08-07 13:47:19 UTC) #5

adg

10 years, 9 months ago (2014-08-07 22:56:49 UTC) #6

*** Submitted as https://code.google.com/p/go/source/detail?r=a57b252cd579 ***

cmd/go: download test dependencies of all named packages

Fixes issue 8181.

LGTM=rsc
R=rsc
CC=golang-codereviews
https://codereview.appspot.com/123870043

Expand All Messages | Collapse All Messages