Issue 12354043: all: use go1.1 features

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12354043: all: use go1.1 features

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by rog

Modified:
10 years, 9 months ago

Reviewers:
dimitern, mp+178343, jameinel

Visibility:
Public.

Description

all: use go1.1 features Use method expressions where appropriate and reflect.SliceOf. There are still a couple more places that could benefit, but they are slightly larger changes that justify a CL of their own. https://code.launchpad.net/~rogpeppe/juju-core/357-method-expressions/+merge/178343 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : all: use go1.1 features #

Total comments: 2

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+48 lines, -67 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cert/cert.go	View	1 chunk	+1 line, -3 lines	2 comments	Download
M	cert/cert_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	cmd/jujud/machine.go	View	2 chunks	+1 line, -5 lines	0 comments	Download
M	cmd/jujud/unit.go	View	1 chunk	+2 lines, -8 lines	0 comments	Download
M	environs/cert_internal_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	state/apiserver/agent/agent.go	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	state/apiserver/machine/agent.go	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	state/apiserver/machine/machiner.go	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	state/megawatcher.go	View	4 chunks	+35 lines, -37 lines	0 comments	Download
M	testing/locking.go	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

jameinel

LGTM https://codereview.appspot.com/12354043/diff/3001/cert/cert.go File cert/cert.go (left): https://codereview.appspot.com/12354043/diff/3001/cert/cert.go#oldcode92 cert/cert.go:92: // Go version 1.1. See Go issue 3791. ...

10 years, 9 months ago (2013-08-08 17:02:07 UTC) #3

rog

10 years, 9 months ago (2013-08-08 17:28:46 UTC) #4

https://codereview.appspot.com/12354043/diff/3001/cert/cert.go
File cert/cert.go (left):

https://codereview.appspot.com/12354043/diff/3001/cert/cert.go#oldcode92
cert/cert.go:92: // Go version 1.1. See Go issue 3791.
On 2013/08/08 17:02:07, jameinel wrote:
> Out of curiosity why is this a go 1.1ism?

see http://golang.org/issue/3791 :-)

Expand All Messages | Collapse All Messages