Move addFile, addScripts to cloudinit.Config

Move addFile, addScripts to cloudinit.Config

Those were buried down into environs/cloudinit.go, and they will be useful
elsewhere for an upcoming branch of mine. Also changed usage of chmod to
'install -m', so the file is created with the correct mode first, and then
written to, which increases security a teensy bit.

https://code.launchpad.net/~sidnei/juju-core/add-scripts-and-file-to-config/+merge/178332

(do not edit description out of merge proposal)

[sidnei.da.silva, 2013-08-02 15:58:39]

Please take a look.

[sidnei.da.silva, 2013-08-02 16:03:35]

Please take a look.

[dimitern, 2013-08-02 16:13:51]

LGTM apart from a minor request

https://codereview.appspot.com/12352043/diff/11002/cloudinit/cloudinit_test.go
File cloudinit/cloudinit_test.go (right):

https://codereview.appspot.com/12352043/diff/11002/cloudinit/cloudinit_test.g...
cloudinit/cloudinit_test.go:223: "runcmd:\n" +
Only this part here is a bit harder to read than the rest. Can you perhaps
define a const string below the test with the expected content and use it here,
rather than concatenating ti like this?

[sidnei.da.silva, 2013-08-02 17:04:34]

Please take a look.

https://codereview.appspot.com/12352043/diff/11002/cloudinit/cloudinit_test.go
File cloudinit/cloudinit_test.go (right):

https://codereview.appspot.com/12352043/diff/11002/cloudinit/cloudinit_test.g...
cloudinit/cloudinit_test.go:223: "runcmd:\n" +
On 2013/08/02 16:13:51, dimitern wrote:
> Only this part here is a bit harder to read than the rest. Can you perhaps
> define a const string below the test with the expected content and use it
here,
> rather than concatenating ti like this?

Done.

[natefinch, 2013-08-02 19:09:29]

LGTM

[natefinch, 2013-08-02 19:16:24]

Suggest changing addscripts to AddRunCmds (makes it more clear that it's not
something completely different, just a helper)