Issue 12343044: Update typography styling per UX.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12343044: Update typography styling per UX.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by rharding

Modified:
10 years, 9 months ago

Reviewers:
mp+178309

Visibility:
Public.

Description

Update typography styling per UX. - This branch is submitted on behalf of Ant. - Please make sure to QA changes in as many browsers as possible. https://code.launchpad.net/~rharding/juju-gui/typography-charm-details/+merge/178309 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Update typography styling per UX. #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -23 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/subapps/browser/templates/browser_charm.handlebars	View	1	1 chunk	+10 lines, -7 lines	0 comments	Download
M	lib/views/browser/charm-full.less	View		2 chunks	+9 lines, -1 line	0 comments	Download
M	lib/views/browser/tabview.less	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	lib/views/typography.less	View		1 chunk	+11 lines, -11 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

benji

LTGM with one tiny comment. https://codereview.appspot.com/12343044/diff/1/app/subapps/browser/templates/browser_charm.handlebars File app/subapps/browser/templates/browser_charm.handlebars (right): https://codereview.appspot.com/12343044/diff/1/app/subapps/browser/templates/browser_charm.handlebars#newcode136 app/subapps/browser/templates/browser_charm.handlebars:136: This looks like it's ...

10 years, 9 months ago (2013-08-02 14:30:10 UTC) #2

rharding

10 years, 9 months ago (2013-08-02 14:52:57 UTC) #4

*** Submitted:

Update typography styling per UX.

- This branch is submitted on behalf of Ant.
- Please make sure to QA changes in as many browsers as possible.

R=benji
CC=
https://codereview.appspot.com/12343044

Expand All Messages | Collapse All Messages