Issue 123330043: cmd/dist: Reuse streq whenever possible.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 123330043: cmd/dist: Reuse streq whenever possible. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by tfarina1

Modified:
10 years, 9 months ago

Reviewers:
iant

CC:
iant, golang-codereviews

Visibility:
Public.

Description

cmd/dist: Reuse streq whenever possible. Basically this cleanup replaces all the usage usages of strcmp() == 0, found by the following command line: $ grep -R strcmp cmd/dist | grep "0"

Patch Set 1 #

Patch Set 2 : diff -r 6316af2a3b922fa9515e0ddd6edfa04922abef00 https://code.google.com/p/go #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -13 lines)			Patch
M	src/cmd/dist/plan9.c	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/cmd/dist/unix.c	View	1	6 chunks	+8 lines, -8 lines	0 comments	Download
M	src/cmd/dist/windows.c	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

tfarina1

trivial cleanup. Is that OK? Tested only on Linux. Thanks for the patience.

10 years, 9 months ago (2014-08-13 03:06:50 UTC) #1

iant

10 years, 9 months ago (2014-08-13 13:47:34 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=7e5e03f84135 ***

cmd/dist: Reuse streq whenever possible.

Basically this cleanup replaces all the usage usages of strcmp() == 0,
found by the following command line:

$ grep -R strcmp cmd/dist | grep "0"

LGTM=iant
R=iant
CC=golang-codereviews
https://codereview.appspot.com/123330043

Committer: Ian Lance Taylor <iant@golang.org>

Expand All Messages | Collapse All Messages