Issue 123250044: code review 123250044: oauth: clean up docs, code, fix data race, don't send c...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 123250044: code review 123250044: oauth: clean up docs, code, fix data race, don't send c... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by bradfitz

Modified:
10 years, 8 months ago

Reviewers:
adg, jbd

CC:
adg, golang-codereviews

Visibility:
Public.

Description

oauth: clean up docs, code, fix data race, don't send client_secret in two places Fixes Issue 31

Patch Set 1 #

Patch Set 2 : diff -r 7fc9d958c83464bd7650240569bf93a102266e6a https://code.google.com/p/goauth2 #

Patch Set 3 : diff -r 7fc9d958c83464bd7650240569bf93a102266e6a https://code.google.com/p/goauth2 #

Patch Set 4 : diff -r 7fc9d958c83464bd7650240569bf93a102266e6a https://code.google.com/p/goauth2 #

Total comments: 1

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+82 lines, -38 lines)			Patch
	M	oauth/oauth.go	View	1	9 chunks	+70 lines, -31 lines	1 comment	Download
	M	oauth/oauth_test.go	View	1	5 chunks	+12 lines, -7 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bradfitz

Hello adg@golang.org (cc: golang-codereviews@googlegroups.com, jbd@google.com), I'd like you to review this change to https://code.google.com/p/goauth2

10 years, 8 months ago (2014-08-12 18:55:43 UTC) #1

bradfitz

*** Submitted as https://code.google.com/p/goauth2/source/detail?r=f06a85362aa5 *** oauth: clean up docs, code, fix data race, don't send ...

10 years, 8 months ago (2014-08-12 20:58:28 UTC) #3

jbd

10 years, 8 months ago (2014-08-13 02:56:16 UTC) #4

Message was sent while issue was closed.

https://codereview.appspot.com/123250044/diff/60001/oauth/oauth.go
File oauth/oauth.go (right):

https://codereview.appspot.com/123250044/diff/60001/oauth/oauth.go#newcode373
oauth/oauth.go:373: // Note that we're not setting v's client_secret to
t.ClientSecret, due
You should set client_secret query param while exchanging code.

https://developers.google.com/accounts/docs/OAuth2WebServer#handlingtheresponse

Expand All Messages | Collapse All Messages