Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(165)

Issue 123240043: code review 123240043: goprotobuf: Split encoding of repeated int32 and repeat... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by dsymonds
Modified:
11 years, 3 months ago
Reviewers:
djd
CC:
djd, golang-codereviews
Visibility:
Public.

Description

goprotobuf: Split encoding of repeated int32 and repeated uint32 fields. This is a follow-on from a previous change where we split the singular int32/uint32. It was an oversight not to fix the repeated versions at the same time. Also simplify setEncAndDec for repeated fields while I'm here. We were doing a lot of unnecessary work: unnecessarily doing two layers of switches, plus trying to handle a bunch of field types we never generate. Fixes issue 52.

Patch Set 1 #

Patch Set 2 : diff -r 6696293829a4 https://code.google.com/p/goprotobuf #

Patch Set 3 : diff -r 6696293829a4 https://code.google.com/p/goprotobuf #

Patch Set 4 : diff -r 6696293829a4 https://code.google.com/p/goprotobuf #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -39 lines) Patch
M proto/encode.go View 4 chunks +72 lines, -3 lines 0 comments Download
M proto/properties.go View 1 chunk +37 lines, -35 lines 0 comments Download
M proto/size_test.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
dsymonds
Hello djd@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/goprotobuf
11 years, 3 months ago (2014-08-12 03:15:03 UTC) #1
djd
LGTM
11 years, 3 months ago (2014-08-12 03:21:13 UTC) #2
dsymonds
11 years, 3 months ago (2014-08-12 03:21:52 UTC) #3
*** Submitted as
https://code.google.com/p/goprotobuf/source/detail?r=36be16571e14 ***

goprotobuf: Split encoding of repeated int32 and repeated uint32 fields.

This is a follow-on from a previous change where we split the singular
int32/uint32.
It was an oversight not to fix the repeated versions at the same time.

Also simplify setEncAndDec for repeated fields while I'm here.
We were doing a lot of unnecessary work: unnecessarily doing two layers of
switches, plus trying to handle a bunch of field types we never generate.

Fixes issue 52.

LGTM=djd
R=djd
CC=golang-codereviews
https://codereview.appspot.com/123240043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b