Issue 123210043: code review 123210043: go.mobile/cmd/gobind: newline after printing errors

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 123210043: code review 123210043: go.mobile/cmd/gobind: newline after printing errors (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by crawshaw

Modified:
10 years, 10 months ago

Reviewers:
minux

CC:
golang-codereviews, minux

Visibility:
Public.

Description

go.mobile/cmd/gobind: newline after printing errors

Patch Set 2 : diff -r 5e7ee6427793f3e761de9578d4af45fdc0364614 https://code.google.com/p/go.mobile #

Patch Set 3 : diff -r 5e7ee6427793f3e761de9578d4af45fdc0364614 https://code.google.com/p/go.mobile #

Total comments: 2

Patch Set 4 : diff -r 73da19a062e77dc7a27d21da79a5c47f1117e21b https://code.google.com/p/go.mobile #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	cmd/gobind/main.go	View	1 2 3	2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

crawshaw

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.mobile

10 years, 10 months ago (2014-08-11 13:39:07 UTC) #1

minux

LGTM. https://codereview.appspot.com/123210043/diff/40001/cmd/gobind/main.go File cmd/gobind/main.go (right): https://codereview.appspot.com/123210043/diff/40001/cmd/gobind/main.go#newcode43 cmd/gobind/main.go:43: fmt.Fprint(os.Stderr, "\n") fmt.Fprintln(os.Stderr) ?

10 years, 10 months ago (2014-08-12 18:23:38 UTC) #2

crawshaw

https://codereview.appspot.com/123210043/diff/40001/cmd/gobind/main.go File cmd/gobind/main.go (right): https://codereview.appspot.com/123210043/diff/40001/cmd/gobind/main.go#newcode43 cmd/gobind/main.go:43: fmt.Fprint(os.Stderr, "\n") On 2014/08/12 18:23:38, minux wrote: > fmt.Fprintln(os.Stderr) ...

10 years, 10 months ago (2014-08-12 18:29:10 UTC) #3

crawshaw

10 years, 10 months ago (2014-08-12 18:29:36 UTC) #4

*** Submitted as
https://code.google.com/p/go/source/detail?r=f74d049c1957&repo=mobile ***

go.mobile/cmd/gobind: newline after printing errors

LGTM=minux
R=golang-codereviews, minux
CC=golang-codereviews
https://codereview.appspot.com/123210043

Expand All Messages | Collapse All Messages