Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(34)

Issue 12320045: code review 12320045: build: ignore new zfiles, delete temp goplay binary in ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by bradfitz
Modified:
10 years, 8 months ago
Reviewers:
rsc
CC:
golang-dev, rsc
Visibility:
Public.

Description

build: ignore new zfiles, delete temp goplay binary in run.bash

Patch Set 1 #

Patch Set 2 : diff -r 92dd5738d64d https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 92dd5738d64d https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 4a3d328fe8e9 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M .hgignore View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M src/run.bash View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4
bradfitz
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
10 years, 8 months ago (2013-08-02 20:26:17 UTC) #1
rsc
LGTM please sort the two new files into place in the hgignore file
10 years, 8 months ago (2013-08-03 01:34:40 UTC) #2
rsc
also, 'rm -f goplay' should suffice. go build writes to the current directory
10 years, 8 months ago (2013-08-03 01:35:01 UTC) #3
bradfitz
10 years, 8 months ago (2013-08-03 02:14:21 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=19591dcb81c6 ***

build: ignore new zfiles, delete temp goplay binary in run.bash

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/12320045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b