Issue 12320044: Add navigation icons to the inspector

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12320044: Add navigation icons to the inspector

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by jeff.pihach

Modified:
10 years, 9 months ago

Reviewers:
benji, mp+178322

Visibility:
Public.

Description

Add navigation icons to the inspector This is a re-proposal of huw's branch: https://codereview.appspot.com/12322043/ There is only a minor padding change to center the icons from his branch. https://code.launchpad.net/~hatch/juju-gui/inspector-icons-and-settings-huw/+merge/178322 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add navigation icons to the inspector #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+71 lines, -11 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
A	app/assets/images/inspector_configuration.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A	app/assets/images/inspector_configuration_selected.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A	app/assets/images/inspector_constraints.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A	app/assets/images/inspector_constraints_selected.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A	app/assets/images/inspector_status.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A	app/assets/images/inspector_status_selected.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	app/templates/viewlet-manager.handlebars	View		1 chunk	+20 lines, -16 lines	0 comments	Download
M	app/views/environment.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	app/views/viewlet-manager.js	View	1	1 chunk	+19 lines, -0 lines	0 comments	Download
M	lib/views/juju-inspector.less	View		2 chunks	+35 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

benji

LGTM https://codereview.appspot.com/12320044/diff/1/app/views/viewlet-manager.js File app/views/viewlet-manager.js (right): https://codereview.appspot.com/12320044/diff/1/app/views/viewlet-manager.js#newcode584 app/views/viewlet-manager.js:584: @method _switchTab @param and @return?

10 years, 9 months ago (2013-08-02 15:19:32 UTC) #2

jeff.pihach

Thanks for the review! https://codereview.appspot.com/12320044/diff/1/app/views/viewlet-manager.js File app/views/viewlet-manager.js (right): https://codereview.appspot.com/12320044/diff/1/app/views/viewlet-manager.js#newcode584 app/views/viewlet-manager.js:584: @method _switchTab OOps I missed ...

10 years, 9 months ago (2013-08-02 15:21:05 UTC) #3

jeff.pihach

10 years, 9 months ago (2013-08-02 15:41:14 UTC) #4

*** Submitted:

Add navigation icons to the inspector

This is a re-proposal of huw's branch: https://codereview.appspot.com/12322043/
There is only a minor padding change to center the icons from his branch.

R=benji
CC=
https://codereview.appspot.com/12320044

Expand All Messages | Collapse All Messages