Issue 12316044: code review 12316044: go.tools/go/types: permit operands of different boolean...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12316044: code review 12316044: go.tools/go/types: permit operands of different boolean... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by gri

Modified:
10 years, 8 months ago

Reviewers:
adonovan

CC:
golang-dev

Visibility:
Public.

go.tools/go/types: permit operands of different boolean types for && and || Per pending spec change (CL 12382043).

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+118 lines, -2 lines)			Patch
M	go/types/expr.go	View	1	3 chunks	+33 lines, -0 lines	0 comments	Download
M	go/types/stdlib_test.go	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	go/types/testdata/expr1.src	View	1	1 chunk	+84 lines, -1 line	0 comments	Download

Total messages: 2

gri

Hello adonovan@google.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools

10 years, 9 months ago (2013-08-03 00:17:28 UTC) #1

*** Abandoned ***