Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1189)

Issue 123150043: Fixed quicklinks overflowing the divs and also their tooltips (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by ajgupta93
Modified:
9 years, 7 months ago
Reviewers:
thomas.j.waldmann, RogerHaase
Visibility:
Public.

Description

Fixed quicklinks overflowing the divs and also their tooltips

Patch Set 1 #

Total comments: 6

Patch Set 2 : Added safe filter to url and displayed only url in tooltip in case title is not there #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -9 lines) Patch
M MoinMoin/templates/layout.html View 1 1 chunk +1 line, -1 line 0 comments Download
M MoinMoin/themes/__init__.py View 1 chunk +3 lines, -1 line 0 comments Download
M MoinMoin/themes/basic/static/css/theme.css View 1 chunk +5 lines, -1 line 0 comments Download
M MoinMoin/themes/basic/static/custom-less/theme.less View 1 chunk +6 lines, -1 line 0 comments Download
M MoinMoin/themes/basic/templates/layout.html View 1 1 chunk +1 line, -4 lines 1 comment Download
M MoinMoin/themes/foobar/templates/layout.html View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
Thomas.J.Waldmann
https://codereview.appspot.com/123150043/diff/1/MoinMoin/templates/layout.html File MoinMoin/templates/layout.html (right): https://codereview.appspot.com/123150043/diff/1/MoinMoin/templates/layout.html#newcode134 MoinMoin/templates/layout.html:134: <a href="{{ url }}" {% if title %}title="{{ title ...
9 years, 7 months ago (2014-08-09 21:45:09 UTC) #1
ajgupta93
https://codereview.appspot.com/123150043/diff/1/MoinMoin/templates/layout.html File MoinMoin/templates/layout.html (right): https://codereview.appspot.com/123150043/diff/1/MoinMoin/templates/layout.html#newcode134 MoinMoin/templates/layout.html:134: <a href="{{ url }}" {% if title %}title="{{ title ...
9 years, 7 months ago (2014-08-10 04:48:04 UTC) #2
RogerHaase
9 years, 7 months ago (2014-08-14 15:07:40 UTC) #3
fix indentation, test one more time, commit

https://codereview.appspot.com/123150043/diff/20001/MoinMoin/themes/basic/tem...
File MoinMoin/themes/basic/templates/layout.html (right):

https://codereview.appspot.com/123150043/diff/20001/MoinMoin/themes/basic/tem...
MoinMoin/themes/basic/templates/layout.html:232: <div class="moin-quicklink">
dedent <div to match </div
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b