Fixed quicklinks overflowing the divs and also their tooltips

Fixed quicklinks overflowing the divs and also their tooltips

[Thomas.J.Waldmann, 2014-08-09 21:45:09]

https://codereview.appspot.com/123150043/diff/1/MoinMoin/templates/layout.html
File MoinMoin/templates/layout.html (right):

https://codereview.appspot.com/123150043/diff/1/MoinMoin/templates/layout.htm...
MoinMoin/templates/layout.html:134: <a href="{{ url }}" {% if title %}title="{{
title }} : {{ url }}"{% endif %}>{{ text }}</a>
jinja2 will escape your url, if e.g. it contains a "&".

https://codereview.appspot.com/123150043/diff/1/MoinMoin/themes/basic/templat...
File MoinMoin/themes/basic/templates/layout.html (right):

https://codereview.appspot.com/123150043/diff/1/MoinMoin/themes/basic/templat...
MoinMoin/themes/basic/templates/layout.html:233: <a class="moin-quicklink-label
{{ cls }}" href="{{ url }}" {% if title %}title="{{ title }} : {{ url }}"{%
endif %}>{{ text|shorten_item_name(20) }}
same url-escape issue here.

also: if you have a "title", you will show title: url.

if you have no title, you won't show anything.

is that intended behaviour?

https://codereview.appspot.com/123150043/diff/1/MoinMoin/themes/foobar/templa...
File MoinMoin/themes/foobar/templates/layout.html (right):

https://codereview.appspot.com/123150043/diff/1/MoinMoin/themes/foobar/templa...
MoinMoin/themes/foobar/templates/layout.html:31: <a href="{{ url }}" {% if title
%}title="{{ title }} : {{ url }}"{% endif %}>{{ text }}</a>
same here

[ajgupta93, 2014-08-10 04:48:04]

https://codereview.appspot.com/123150043/diff/1/MoinMoin/templates/layout.html
File MoinMoin/templates/layout.html (right):

https://codereview.appspot.com/123150043/diff/1/MoinMoin/templates/layout.htm...
MoinMoin/templates/layout.html:134: <a href="{{ url }}" {% if title %}title="{{
title }} : {{ url }}"{% endif %}>{{ text }}</a>
On 2014/08/09 21:45:09, Thomas.J.Waldmann wrote:
> jinja2 will escape your url, if e.g. it contains a "&".

Done.

https://codereview.appspot.com/123150043/diff/1/MoinMoin/themes/basic/templat...
File MoinMoin/themes/basic/templates/layout.html (right):

https://codereview.appspot.com/123150043/diff/1/MoinMoin/themes/basic/templat...
MoinMoin/themes/basic/templates/layout.html:233: <a class="moin-quicklink-label
{{ cls }}" href="{{ url }}" {% if title %}title="{{ title }} : {{ url }}"{%
endif %}>{{ text|shorten_item_name(20) }}
On 2014/08/09 21:45:09, Thomas.J.Waldmann wrote:
> same url-escape issue here.
> 
> also: if you have a "title", you will show title: url.
> 
> if you have no title, you won't show anything.
> 
> is that intended behaviour?
I changed that to display only url in case title is not there

https://codereview.appspot.com/123150043/diff/1/MoinMoin/themes/foobar/templa...
File MoinMoin/themes/foobar/templates/layout.html (right):

https://codereview.appspot.com/123150043/diff/1/MoinMoin/themes/foobar/templa...
MoinMoin/themes/foobar/templates/layout.html:31: <a href="{{ url }}" {% if title
%}title="{{ title }} : {{ url }}"{% endif %}>{{ text }}</a>
On 2014/08/09 21:45:09, Thomas.J.Waldmann wrote:
> same here

Done.

[RogerHaase, 2014-08-14 15:07:40]

fix indentation, test one more time, commit

https://codereview.appspot.com/123150043/diff/20001/MoinMoin/themes/basic/tem...
File MoinMoin/themes/basic/templates/layout.html (right):

https://codereview.appspot.com/123150043/diff/20001/MoinMoin/themes/basic/tem...
MoinMoin/themes/basic/templates/layout.html:232: <div class="moin-quicklink">
dedent <div to match </div