Issue 12308044: Plugins do their own argument processing

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12308044: Plugins do their own argument processing (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by wallyworld

Modified:
10 years, 8 months ago

Reviewers:
dimitern, mp+178198, fwereade, rog

Visibility:
Public.

Description

Plugins do their own argument processing Juju now just passes all args directly to the plugins, which are responsible for doing their own parsing etc. This removes the need for having to use "--", but plugins now need to look at things like -e themselves. I also removed some duplicate tests and added some tests to ensure the built in plugins were registered correctly and properly output help text. https://code.launchpad.net/~wallyworld/juju-core/plugin-arg-handing/+merge/178198 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+97 lines, -153 lines)			Patch
[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
cmd/juju/metadataplugin_test.go	View	1 chunk	+68 lines, -0 lines	0 comments	Download
cmd/juju/plugin.go	View	4 chunks	+2 lines, -20 lines	0 comments	Download
cmd/juju/plugin_test.go	View	3 chunks	+24 lines, -21 lines	0 comments	Download
cmd/plugins/juju-metadata/metadata_test.go	View	1 chunk	+0 lines, -111 lines	0 comments	Download
cmd/supercommand.go	View	1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dimitern

Can you please repropose this, the diff is missing for most of the files.

10 years, 9 months ago (2013-08-07 13:29:46 UTC) #3

rog

10 years, 9 months ago (2013-08-07 16:00:40 UTC) #4

LGTM, thanks.

Given this change, do we still need to respect
the JUJU_ENV environment variable, or was that
considered useful independent of this?

https://codereview.appspot.com/12308044/diff/1/cmd/supercommand.go
File cmd/supercommand.go (right):

https://codereview.appspot.com/12308044/diff/1/cmd/supercommand.go#newcode447
cmd/supercommand.go:447: 
yay!

Expand All Messages | Collapse All Messages