code review 122910043: path/filepath: do not restore original working director...

path/filepath: do not restore original working directory twice in test

[brainman, 2014-08-06 07:15:29]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[dave_cheney.net, 2014-08-06 08:18:33]

LGTM. You can never be to sure it seems.
On 6 Aug 2014 17:15, <alex.brainman@gmail.com> wrote:

> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> path/filepath: do not restore original working directory twice in test
>
> Please review this at https://codereview.appspot.com/122910043/
>
> Affected files (+0, -6 lines):
>   M src/pkg/path/filepath/path_test.go
>
>
> Index: src/pkg/path/filepath/path_test.go
> ===================================================================
> --- a/src/pkg/path/filepath/path_test.go
> +++ b/src/pkg/path/filepath/path_test.go
> @@ -784,12 +784,6 @@
>  }
>
>  func TestAbs(t *testing.T) {
> -       oldwd, err := os.Getwd()
> -       if err != nil {
> -               t.Fatal("Getwd failed: ", err)
> -       }
> -       defer os.Chdir(oldwd)
> -
>         root, err := ioutil.TempDir("", "TestAbs")
>         if err != nil {
>                 t.Fatal("TempDir failed: ", err)
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[brainman, 2014-08-07 00:22:19]

*** Submitted as https://code.google.com/p/go/source/detail?r=958fad6b8dd2 ***

path/filepath: do not restore original working directory twice in test

LGTM=dave
R=golang-codereviews, dave
CC=golang-codereviews
https://codereview.appspot.com/122910043

[gobot, 2014-08-07 01:04:25]

This CL appears to have broken the openbsd-386-crawshaw builder.
See http://build.golang.org/log/eb9f2a0c33b1e9b38a6e3217ef89af3fcc7157f4