Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1281)

Issue 122680043: code review 122680043: runtime: cache unrolled GC bitmask (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by dvyukov
Modified:
10 years, 6 months ago
Reviewers:
gobot, rsc
CC:
golang-codereviews, rsc, khr, rlh
Visibility:
Public.

Description

runtime: cache unrolled GC bitmask Cache unrolled GC bitmask for types up to 64/32K on 64/32-bit systems, this corresponds to up to 4K cached bitmask. Perf builders say that 2% of time is spent in unrollgcproginplace_m/unrollgcprog1 on http benchmark: http://goperfd.appspot.com/log/f42045f45bf61a0da53b724a7c8567824a0ad6c9

Patch Set 1 #

Patch Set 2 : diff -r 88dc2cecad6ba572cf063170e0d94b8291af4a7f https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 88dc2cecad6ba572cf063170e0d94b8291af4a7f https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 9985ecf9828f87d8887550109060357e2163ab8a https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 5 : diff -r d290f48255fb933439916159ecd5301c5bb5c301 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 6 : diff -r a06a6f2f924fc42cacaf4d2e4230ca9cd272a4f7 https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/pkg/runtime/malloc.go View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/mgc0.h View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11
dvyukov
Hello golang-codereviews@googlegroups.com (cc: khr@golang.org, rlh@golang.org, rsc@golang.org), I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
10 years, 7 months ago (2014-08-15 19:24:34 UTC) #1
rsc
NOT LGTM We already had this discussion. I want to see some attention paid to ...
10 years, 7 months ago (2014-08-15 19:25:17 UTC) #2
rsc
Another thing I'd like to see is what size is actually needed. Why not MaxGCMask ...
10 years, 7 months ago (2014-08-15 19:27:14 UTC) #3
dvyukov
I've collected unroll stats on godoc after serving a dozen of different pages. Here are ...
10 years, 6 months ago (2014-08-20 13:09:36 UTC) #4
dvyukov
PTAL
10 years, 6 months ago (2014-08-20 13:19:16 UTC) #5
rsc
On Wed, Aug 20, 2014 at 9:09 AM, <dvyukov@google.com> wrote: > Here are all types ...
10 years, 6 months ago (2014-08-20 18:11:22 UTC) #6
dvyukov
Here are types with [33-64] masks in std lib: 56 png.decoder 49 json.Decoder 47 pkix.CertificateList ...
10 years, 6 months ago (2014-08-21 11:09:25 UTC) #7
dvyukov
set maxGCMask to 64 PTAL
10 years, 6 months ago (2014-08-21 11:11:28 UTC) #8
rsc
LGTM
10 years, 6 months ago (2014-08-23 22:57:28 UTC) #9
dvyukov
*** Submitted as https://code.google.com/p/go/source/detail?r=6878eb672373 *** runtime: cache unrolled GC bitmask Cache unrolled GC bitmask for ...
10 years, 6 months ago (2014-08-24 08:04:55 UTC) #10
gobot
10 years, 6 months ago (2014-08-24 10:54:59 UTC) #11
Message was sent while issue was closed.
This CL appears to have broken the freebsd-amd64-race builder.
See http://build.golang.org/log/41b29b4ea40f7f102f6e75e31bf41e1e655ba695
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b