code review 12267043: runtime: in newstack, double-check calling goroutine

runtime: in newstack, double-check calling goroutine

Checking this condition helped me find the arm problem last night.

[rsc, 2013-08-02 16:07:18]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2013-08-02 16:16:01]

LGTM



On Fri, Aug 2, 2013 at 9:07 AM, <rsc@golang.org> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> runtime: in newstack, double-check calling goroutine
>
> Checking this condition helped me find the arm problem last night.
>
> Please review this at
https://codereview.appspot.**com/12267043/<https://codereview.appspot.com/122...
>
> Affected files:
>   M src/pkg/runtime/stack.c
>
>
> Index: src/pkg/runtime/stack.c
> ==============================**==============================**=======
> --- a/src/pkg/runtime/stack.c
> +++ b/src/pkg/runtime/stack.c
> @@ -201,6 +201,13 @@
>         bool reflectcall;
>         uintptr free;
>
> +       if(m->morebuf.g != m->curg) {
> +               runtime·printf("runtime: newstack called from g=%p\n"
> +                       "\tm=%p m->curg=%p m->g0=%p m->gsignal=%p\n",
> +                       m->morebuf.g, m, m->curg, m->g0, m->gsignal);
> +               runtime·throw("runtime: wrong goroutine in newstack");
> +       }
> +
>         // gp->status is usually Grunning, but it could be Gsyscall if a
> stack split
>         // happens during a function call inside entersyscall.
>         gp = m->curg;
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[rsc, 2013-08-02 17:51:34]

*** Submitted as https://code.google.com/p/go/source/detail?r=0903c4861b0f ***

runtime: in newstack, double-check calling goroutine

Checking this condition helped me find the arm problem last night.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/12267043