Issue 12253043: code review 12253043: runtime: make new tests shorter in short mode

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12253043: code review 12253043: runtime: make new tests shorter in short mode (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by dvyukov

Modified:
11 years, 10 months ago

Reviewers:
r

CC:
golang-dev, r

Visibility:
Public.

Description

runtime: make new tests shorter in short mode We see timeouts in these tests on some platforms, but not on the others. The hypothesis is that the problematic platforms are slow uniprocessors. Stack traces do not suggest that the process is completely hang, and it is able to schedule the alarm goroutine. And if it actually hangs, we still will be able to detect that.

Patch Set 1 #

Patch Set 2 : diff -r 9e6bf9246b90 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 9e6bf9246b90 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 9e6bf9246b90 https://dvyukov%40google.com@code.google.com/p/go/ #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -5 lines)			Patch
	M	src/pkg/runtime/proc_test.go	View	1	4 chunks	+18 lines, -5 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dvyukov

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/

11 years, 10 months ago (2013-08-01 14:06:42 UTC) #1

dvyukov

11 years, 10 months ago (2013-08-01 14:25:45 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=025779e75fda ***

runtime: make new tests shorter in short mode
We see timeouts in these tests on some platforms,
but not on the others.  The hypothesis is that
the problematic platforms are slow uniprocessors.
Stack traces do not suggest that the process
is completely hang, and it is able to schedule
the alarm goroutine. And if it actually hangs,
we still will be able to detect that.

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/12253043

Expand All Messages | Collapse All Messages