Issue 122480043: Remove version constraints for plugins required to build tools.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 122480043: Remove version constraints for plugins required to build tools. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 8 months ago by roubert (google)

Modified:
9 years, 8 months ago

Reviewers:
Shaopeng

CC:
daniel2, lararennie

Base URL:
https://libphonenumber.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Remove version constraints for plugins required to build tools. Normally it is not a good idea to place <version> constraints in the definition of plugins in pom.xml unless a specific version really is needed. This patch removes the constraints. There are various benefits to this, one of them is that it will always build with the latest packaged version of the plugins on a Debian or Ubuntu system. Author: daniel@pocock.pro R=jia.shao.peng@gmail.com BUG= Committed: https://code.google.com/p/libphonenumber/source/detail?r=682

Patch Set 1 #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -13 lines)			Patch
M	tools/java/common/pom.xml	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	tools/java/cpp-build/pom.xml	View	4 chunks	+0 lines, -4 lines	0 comments	Download
M	tools/java/data/pom.xml	View	3 chunks	+0 lines, -4 lines	0 comments	Download
M	tools/java/java-build/pom.xml	View	3 chunks	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Shaopeng

LGTM. Sorry for the delay - had a really busy week last week.

9 years, 8 months ago (2014-08-18 10:02:52 UTC) #2

roubert (google)

9 years, 8 months ago (2014-08-18 17:02:06 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as 682 (presubmit successful).

Expand All Messages | Collapse All Messages