Issue 12246043: code review 12246043: runtime: fix netbsd/arm build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12246043: code review 12246043: runtime: fix netbsd/arm build (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by dvyukov

Modified:
11 years, 10 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

runtime: fix netbsd/arm build Currently fails with: fatal error: runtime: stack split during syscall goroutine 2 [stack split]: _vasop(0x3ac4a0, 0x505f8f00, 0x7a5a8, 0x7, 0x1ed3797f, ...) src/pkg/runtime/vlrt_arm.c:513 fp=0x505f8ecc runtime.semasleep(0xf8475800, 0xd) src/pkg/runtime/os_netbsd.c:97 +0x178 fp=0x505f8efc

Patch Set 1 #

Patch Set 2 : diff -r 3ffed73b911b https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 3ffed73b911b https://dvyukov%40google.com@code.google.com/p/go/ #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/pkg/runtime/os_netbsd.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

dvyukov

Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/

11 years, 10 months ago (2013-08-01 11:19:42 UTC) #1

dvyukov

11 years, 10 months ago (2013-08-01 11:20:10 UTC) #2

*** Submitted as https://code.google.com/p/go/source/detail?r=b5442e956dd0 ***

runtime: fix netbsd/arm build
Currently fails with:
fatal error: runtime: stack split during syscall
goroutine 2 [stack split]:
_vasop(0x3ac4a0, 0x505f8f00, 0x7a5a8, 0x7, 0x1ed3797f, ...)
        src/pkg/runtime/vlrt_arm.c:513 fp=0x505f8ecc
runtime.semasleep(0xf8475800, 0xd)
        src/pkg/runtime/os_netbsd.c:97 +0x178 fp=0x505f8efc

R=rsc
CC=golang-dev
https://codereview.appspot.com/12246043

Expand All Messages | Collapse All Messages