Issue 1224043: preparation for migration

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 11 months ago by calidion

Modified:
7 years, 4 months ago

Reviewers:
xan, weiliu, baiming, leio.chen, lychen, qiaojian, quguangfan, heian911

CC:
xinxing_google.com, lishuangfeng_gmail.com

Base URL:
http://scheduleeditor.googlecode.com/svn/trunk/python/

Visibility:
Public.

Patch Set 3 : fill the empty file with comments #

Patch Set 4 : updated #

Created: 13 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5282 lines, -5254 lines)			Patch
A	gtfsscheduleeditor/__init__.py	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download
A	gtfsscheduleeditor/files/index.html	View		1 chunk	+72 lines, -0 lines	0 comments	Download
A	gtfsscheduleeditor/files/labeled_marker.js	View		1 chunk	+179 lines, -0 lines	0 comments	Download
A	gtfsscheduleeditor/files/mm_20_blue.png	View		Binary file		0 comments	Download
A	gtfsscheduleeditor/files/mm_20_blue_trans.png	View		Binary file		0 comments	Download
A	gtfsscheduleeditor/files/mm_20_red_trans.png	View		Binary file		0 comments	Download
A	gtfsscheduleeditor/files/mm_20_shadow.png	View		Binary file		0 comments	Download
A	gtfsscheduleeditor/files/mm_20_shadow_trans.png	View		Binary file		0 comments	Download
A	gtfsscheduleeditor/files/mm_20_yellow.png	View		Binary file		0 comments	Download
A	gtfsscheduleeditor/files/pin.png	View		Binary file		0 comments	Download
A	gtfsscheduleeditor/files/style.css	View		1 chunk	+194 lines, -0 lines	0 comments	Download
A	gtfsscheduleeditor/files/transit_editor.js	View		1 chunk	+4801 lines, -0 lines	0 comments	Download
D	gtfsscheduleviewer/files/index.html	View		1 chunk	+0 lines, -72 lines	0 comments	Download
D	gtfsscheduleviewer/files/labeled_marker.js	View		1 chunk	+0 lines, -179 lines	0 comments	Download
D	gtfsscheduleviewer/files/mm_20_blue.png	View		Binary file		0 comments	Download
D	gtfsscheduleviewer/files/mm_20_blue_trans.png	View		Binary file		0 comments	Download
D	gtfsscheduleviewer/files/mm_20_red.png	View		Binary file		0 comments	Download
D	gtfsscheduleviewer/files/mm_20_red_trans.png	View		Binary file		0 comments	Download
D	gtfsscheduleviewer/files/mm_20_shadow.png	View		Binary file		0 comments	Download
D	gtfsscheduleviewer/files/mm_20_shadow_trans.png	View		Binary file		0 comments	Download
D	gtfsscheduleviewer/files/mm_20_yellow.png	View		Binary file		0 comments	Download
D	gtfsscheduleviewer/files/pin.png	View		Binary file		0 comments	Download
D	gtfsscheduleviewer/files/style.css	View		1 chunk	+0 lines, -194 lines	0 comments	Download
D	gtfsscheduleviewer/files/svgcheck.vbs	View		1 chunk	+0 lines, -7 lines	0 comments	Download
D	gtfsscheduleviewer/files/transit_editor.js	View		1 chunk	+0 lines, -4801 lines	0 comments	Download
M	schedule_editor.py	View	1 2 3	2 chunks	+31 lines, -0 lines	0 comments	Download
M	transitfeed_editor.py	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

weiliu

http://codereview.appspot.com/1224043/diff/1/11 File gtfsscheduleeditor/files/index.html (right): http://codereview.appspot.com/1224043/diff/1/11#newcode1 gtfsscheduleeditor/files/index.html:1: <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" You are ...

13 years, 11 months ago (2010-05-19 08:42:56 UTC) #2

calidion

13 years, 11 months ago (2010-05-19 09:36:09 UTC) #3

weiliu

I still didn't understand why you kept an empty file, maybe you can take this ...

13 years, 11 months ago (2010-05-19 09:48:02 UTC) #4

calidion

updated http://codereview.appspot.com/1224043/diff/12001/13027 File schedule_editor.py (right): http://codereview.appspot.com/1224043/diff/12001/13027#newcode434 schedule_editor.py:434: default directory. same file. line: 372 On 2010/05/19 ...

13 years, 11 months ago (2010-05-19 09:55:37 UTC) #5

weiliu

LGTM On Wed, May 19, 2010 at 5:55 PM, <calidion@gmail.com> wrote: > updated > > ...

13 years, 11 months ago (2010-05-19 09:57:43 UTC) #6

calidion

13 years, 11 months ago (2010-05-19 10:00:35 UTC) #7

updated to rev 83

2010/5/19 Wei Liu <weiliu@google.com>

> LGTM
>
>
> On Wed, May 19, 2010 at 5:55 PM, <calidion@gmail.com> wrote:
>
>> updated
>>
>>
>>
>> http://codereview.appspot.com/1224043/diff/12001/13027
>> File schedule_editor.py (right):
>>
>> http://codereview.appspot.com/1224043/diff/12001/13027#newcode434
>> schedule_editor.py:434: default directory.
>> same file.
>> line: 372
>>
>>
>> On 2010/05/19 09:48:03, weiliu wrote:
>>
>>> in main function -> in the main function
>>> Is is -> It is
>>>
>>
>>  and where is main function? In this file? Seems not.
>>>
>>
>> http://codereview.appspot.com/1224043/show
>>
>
>
>
> --
> Best Regards,
> Wei Liu
> 86-10-62503256(o)
>

Expand All Messages | Collapse All Messages