Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(437)

Issue 12216043: gsoc-2013-bge-lod

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 months, 2 weeks ago by Kupoman
Modified:
4 months ago
Reviewers:
Moguri, bf-codereview-request, brechtvl
Base URL:
https://svn.blender.org/svnroot/bf-blender/trunk/blender/
Visibility:
Public.

Description

gsoc-2013-bge-lod

Patch Set 1 #

Total comments: 32
Unified diffs Side-by-side diffs Delta from patch set Stats (+700 lines, -4 lines) Patch
M release/scripts/startup/bl_operators/object.py View 1 chunk +151 lines, -0 lines 4 comments Download
M release/scripts/startup/bl_ui/properties_object.py View 2 chunks +39 lines, -1 line 1 comment Download
M source/blender/blenkernel/BKE_object.h View 1 chunk +7 lines, -0 lines 0 comments Download
M source/blender/blenkernel/intern/object.c View 8 chunks +144 lines, -0 lines 6 comments Download
M source/blender/blenloader/intern/readfile.c View 3 chunks +30 lines, -0 lines 4 comments Download
M source/blender/blenloader/intern/writefile.c View 1 chunk +2 lines, -0 lines 0 comments Download
M source/blender/editors/object/CMakeLists.txt View 1 chunk +1 line, -0 lines 0 comments Download
M source/blender/editors/object/object_intern.h View 1 chunk +4 lines, -0 lines 0 comments Download
A source/blender/editors/object/object_lod.c View 1 chunk +102 lines, -0 lines 4 comments Download
M source/blender/editors/object/object_ops.c View 1 chunk +3 lines, -0 lines 0 comments Download
M source/blender/editors/space_view3d/drawobject.c View 1 chunk +8 lines, -0 lines 4 comments Download
M source/blender/editors/space_view3d/space_view3d.c View 1 chunk +4 lines, -0 lines 0 comments Download
M source/blender/editors/space_view3d/view3d_draw.c View 5 chunks +24 lines, -1 line 0 comments Download
M source/blender/gpu/intern/gpu_draw.c View 1 chunk +5 lines, -0 lines 2 comments Download
M source/blender/makesdna/DNA_object_types.h View 2 chunks +10 lines, -0 lines 0 comments Download
M source/blender/makesrna/intern/rna_object.c View 5 chunks +60 lines, -0 lines 2 comments Download
M source/blender/windowmanager/WM_types.h View 1 chunk +1 line, -0 lines 2 comments Download
M source/gameengine/Converter/BL_BlenderDataConversion.cpp View 3 chunks +28 lines, -2 lines 0 comments Download
M source/gameengine/Ketsji/KX_Dome.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M source/gameengine/Ketsji/KX_GameObject.h View 2 chunks +20 lines, -0 lines 2 comments Download
M source/gameengine/Ketsji/KX_GameObject.cpp View 2 chunks +34 lines, -0 lines 1 comment Download
M source/gameengine/Ketsji/KX_KetsjiEngine.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M source/gameengine/Ketsji/KX_Scene.h View 1 chunk +3 lines, -0 lines 0 comments Download
M source/gameengine/Ketsji/KX_Scene.cpp View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 12
Kupoman
I would like to get this work into Trunk for 2.69. Any review would be ...
8 months, 2 weeks ago #1
Moguri
I've done a quick review of the BGE parts. https://codereview.appspot.com/12216043/diff/1/source/gameengine/Ketsji/KX_GameObject.cpp File source/gameengine/Ketsji/KX_GameObject.cpp (right): https://codereview.appspot.com/12216043/diff/1/source/gameengine/Ketsji/KX_GameObject.cpp#newcode723 source/gameengine/Ketsji/KX_GameObject.cpp:723: ...
8 months, 1 week ago #2
brechtvl
What is the situation now, did any of the game engine developers do a full ...
7 months, 1 week ago #3
Kupoman
Mitchell Stokes did a review for the BGE parts of the patch. Joerg Mueller (my ...
7 months, 1 week ago #4
brechtvl
https://codereview.appspot.com/12216043/diff/1/release/scripts/startup/bl_operators/object.py File release/scripts/startup/bl_operators/object.py (right): https://codereview.appspot.com/12216043/diff/1/release/scripts/startup/bl_operators/object.py#newcode783 release/scripts/startup/bl_operators/object.py:783: bl_label = "Setup Level of Details By Name" Change ...
7 months, 1 week ago #5
brechtvl
A big problem with the viewport display of levels of detail is that it's not ...
7 months, 1 week ago #6
brechtvl
The simple way to make it show correct results and work with the depsgraph would ...
7 months ago #7
Kupoman
Fixed most of the issues brought up from code review so far. Thank you Brecht ...
7 months ago #8
Kupoman
https://codereview.appspot.com/12216043/diff/1/source/blender/blenloader/intern/readfile.c File source/blender/blenloader/intern/readfile.c (right): https://codereview.appspot.com/12216043/diff/1/source/blender/blenloader/intern/readfile.c#newcode5038 source/blender/blenloader/intern/readfile.c:5038: ob->currentlod = ob->lodlevels.first; On 2013/09/13 16:57:49, brechtvl wrote: > ...
7 months ago #9
brechtvl
On 2013/09/14 02:35:49, Kupoman wrote: > https://codereview.appspot.com/12216043/diff/1/source/blender/blenloader/intern/readfile.c > File source/blender/blenloader/intern/readfile.c (right): > > https://codereview.appspot.com/12216043/diff/1/source/blender/blenloader/intern/readfile.c#newcode5038 > ...
7 months ago #10
brechtvl
What is the status here? This seems close to ready for 2.70, just some minor ...
4 months ago #11
Kupoman
4 months ago #12
On 2013/12/15 15:13:49, brechtvl wrote:
> What is the status here? This seems close to ready for 2.70, just some minor
> things to fix?

As far as I know most (if not all) of the issues were addressed except for
potential conflicts with depsgraph refactors. I have created a Differential
Revision to continue this process on the new tools:
http://developer.blender.org/D109

Hopefully I did it correctly.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5