Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1157)

Issue 122130043: code review 122130043: runtime: shrink stacks in parallel (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by dvyukov
Modified:
10 years, 7 months ago
Reviewers:
khr1, rlh
CC:
golang-codereviews, khr1, khr, rlh, rsc
Visibility:
Public.

Description

runtime: shrink stacks in parallel Shrinkstack does not touch normal heap anymore, so we can shink stacks concurrently with marking.

Patch Set 1 #

Patch Set 2 : diff -r 88999b670ed9 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 88999b670ed9 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r cf99a05f0fbc945aefe2acbf92a2d050ec58b6a1 https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M src/pkg/runtime/mgc0.c View 1 2 3 3 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 5
dvyukov
Hello golang-codereviews@googlegroups.com (cc: khr@golang.org, rsc@golang.org), I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
10 years, 7 months ago (2014-08-05 21:04:40 UTC) #1
rsc
R=khr
10 years, 7 months ago (2014-08-05 21:15:16 UTC) #2
khr1
LGTM. On Tue, Aug 5, 2014 at 2:15 PM, Russ Cox <rsc@golang.org> wrote: > R=khr ...
10 years, 7 months ago (2014-08-06 20:31:17 UTC) #3
dvyukov
*** Submitted as https://code.google.com/p/go/source/detail?r=739dc7f55e3f *** runtime: shrink stacks in parallel Shrinkstack does not touch normal ...
10 years, 7 months ago (2014-08-07 08:55:34 UTC) #4
rlh
10 years, 7 months ago (2014-08-07 13:46:48 UTC) #5
Stacks get shrink, the old one is freed, and the new one scanned. This
would seem to foreclose the option of concurrent scans of the same stack
which I'm not objecting too, I'm just noting it.
LGTM


On Thu, Aug 7, 2014 at 4:55 AM, <dvyukov@google.com> wrote:

> *** Submitted as
> https://code.google.com/p/go/source/detail?r=739dc7f55e3f ***
>
> runtime: shrink stacks in parallel
> Shrinkstack does not touch normal heap anymore,
> so we can shink stacks concurrently with marking.
>
> LGTM=khr
> R=golang-codereviews, khr
> CC=golang-codereviews, khr, rlh, rsc
> https://codereview.appspot.com/122130043
>
>
> https://codereview.appspot.com/122130043/
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b