LGTM. Indeed it is unused, and hasn't been since Go 1.1 On Tue, Aug 5, ...
10 years, 9 months ago
(2014-08-05 03:26:51 UTC)
#3
LGTM. Indeed it is unused, and hasn't been since Go 1.1
On Tue, Aug 5, 2014 at 1:23 PM, <iant@golang.org> wrote:
> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> runtime: remove unused enum maxround
>
> Please review this at https://codereview.appspot.com/122030043/
>
> Affected files (+0, -4 lines):
> M src/pkg/runtime/runtime.c
>
>
> Index: src/pkg/runtime/runtime.c
> ===================================================================
> --- a/src/pkg/runtime/runtime.c
> +++ b/src/pkg/runtime/runtime.c
> @@ -7,10 +7,6 @@
> #include "arch_GOARCH.h"
> #include "../../cmd/ld/textflag.h"
>
> -enum {
> - maxround = sizeof(uintptr),
> -};
> -
> // Keep a cached value to make gotraceback fast,
> // since we call it on every call to gentraceback.
> // The cached value is a uint32 in which the low bit
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
Issue 122030043: code review 122030043: runtime: remove unused enum maxround
(Closed)
Created 10 years, 9 months ago by iant
Modified 10 years, 9 months ago
Reviewers:
Base URL:
Comments: 0