Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(52)

Issue 12202043: code review 12202043: undo CL 12193043 / cc5858966b08 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 9 months ago by bradfitz
Modified:
11 years, 9 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

undo CL 12193043 / cc5858966b08 Breaks all ELF builds. ««« original CL description cmd/ld: report pclntab, funcdata sizes in 6l -v output Also move chatty recent additions to -v -v. For what it's worth: $ go build -o /dev/null -ldflags -v cmd/godoc ... 0.73 pclntab=1259976 bytes, funcdata total 79788 bytes ... $ R=ken2 CC=cshapiro, golang-dev https://codereview.appspot.com/12193043 »»»

Patch Set 1 #

Patch Set 2 : diff -r 2627f7ba15d2 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 2627f7ba15d2 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -15 lines) Patch
M src/cmd/ld/lib.c View 1 7 chunks +5 lines, -15 lines 0 comments Download

Messages

Total messages: 2
bradfitz
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 9 months ago (2013-07-31 22:30:06 UTC) #1
bradfitz
11 years, 9 months ago (2013-07-31 22:31:52 UTC) #2
*** Submitted as https://code.google.com/p/go/source/detail?r=d656f46cfb72 ***

undo CL 12193043 / cc5858966b08

Breaks all ELF builds.

««« original CL description
       cmd/ld: report pclntab, funcdata sizes in 6l -v output
       Also move chatty recent additions to -v -v.

       For what it's worth:

       $ go build -o /dev/null -ldflags -v cmd/godoc
       ...
        0.73 pclntab=1259976 bytes, funcdata total 79788 bytes
       ...
       $

R=ken2
CC=cshapiro, golang-dev
https://codereview.appspot.com/12193043
»»»

R=rsc
CC=golang-dev
https://codereview.appspot.com/12202043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b