Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1332)

Issue 121920043: code review 121920043: runtime: cast to uintptr to match %p formatter. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by khr
Modified:
10 years, 9 months ago
Reviewers:
brainman, bradfitz
CC:
golang-codereviews, bradfitz
Visibility:
Public.

Description

runtime: cast to uintptr to match %p formatter.

Patch Set 1 #

Patch Set 2 : diff -r ec4b62f06a49 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/pkg/runtime/os_windows_386.c View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
khr
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
10 years, 9 months ago (2014-07-31 03:00:31 UTC) #1
bradfitz
LGTM On Wednesday, July 30, 2014, <khr@golang.org> wrote: > Reviewers: golang-codereviews, > > Message: > ...
10 years, 9 months ago (2014-07-31 03:01:59 UTC) #2
khr
*** Submitted as https://code.google.com/p/go/source/detail?r=455d073a9dd7 *** runtime: cast to uintptr to match %p formatter. LGTM=bradfitz R=golang-codereviews, ...
10 years, 9 months ago (2014-07-31 03:24:11 UTC) #3
brainman
10 years, 9 months ago (2014-07-31 03:50:03 UTC) #4
Message was sent while issue was closed.
That does the trick. Thank you.

Alex
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b