LGTM On Wednesday, July 30, 2014, <khr@golang.org> wrote: > Reviewers: golang-codereviews, > > Message: > ...
10 years, 9 months ago
(2014-07-31 03:01:59 UTC)
#2
LGTM
On Wednesday, July 30, 2014, <khr@golang.org> wrote:
> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> runtime: cast to uintptr to match %p formatter.
>
> Please review this at https://codereview.appspot.com/121920043/
>
> Affected files (+1, -1 lines):
> M src/pkg/runtime/os_windows_386.c
>
>
> Index: src/pkg/runtime/os_windows_386.c
> ===================================================================
> --- a/src/pkg/runtime/os_windows_386.c
> +++ b/src/pkg/runtime/os_windows_386.c
> @@ -97,7 +97,7 @@
> runtime·panicking = 1;
>
> runtime·printf("Exception %x %p %p %p\n", info->ExceptionCode,
> - info->ExceptionInformation[0],
> info->ExceptionInformation[1], r->Eip);
> + (uintptr)info->ExceptionInformation[0],
(uintptr)info->ExceptionInformation[1],
> (uintptr)r->Eip);
>
> runtime·printf("PC=%x\n", r->Eip);
> if(g->m->lockedg != nil && g->m->ncgo > 0 && gp == g->m->g0) {
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
*** Submitted as https://code.google.com/p/go/source/detail?r=455d073a9dd7 *** runtime: cast to uintptr to match %p formatter. LGTM=bradfitz R=golang-codereviews, ...
10 years, 9 months ago
(2014-07-31 03:24:11 UTC)
#3
Issue 121920043: code review 121920043: runtime: cast to uintptr to match %p formatter.
(Closed)
Created 10 years, 9 months ago by khr
Modified 10 years, 9 months ago
Reviewers: brainman
Base URL:
Comments: 0