Issue 12189043: code review 12189043: godoc: Fix jump-to-line in source view.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12189043: code review 12189043: godoc: Fix jump-to-line in source view.

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by folke

Modified:
12 years, 5 months ago

Reviewers:
adg

CC:
adg, bradfitz, golang-dev

Visibility:
Public.

Description

go.tools/godoc: Fix jump-to-line in source view. Remove the empty anchor element and add the line ID (Lnnn) to the span element that contains the line number. Fixes issue 5977.

Patch Set 1 #

Patch Set 2 : diff -r c72ffa74432d https://code.google.com/p/go.tools/ #

Patch Set 3 : diff -r c72ffa74432d https://code.google.com/p/go.tools/ #

Patch Set 4 : diff -r 93e42b136c78 https://code.google.com/p/go.tools/ #

Patch Set 5 : diff -r 93e42b136c78 https://code.google.com/p/go.tools/ #

Patch Set 6 : diff -r 93e42b136c78 https://code.google.com/p/go.tools/ #

Patch Set 7 : diff -r 93e42b136c78 https://code.google.com/p/go.tools/ #

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	godoc/format.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

folke

Hello adg@golang.org, bradfitz@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools/

12 years, 5 months ago (2013-07-31 18:23:17 UTC) #1

adg

12 years, 5 months ago (2013-08-01 01:52:31 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=899f0c465799&repo=tools ***

go.tools/godoc: Fix jump-to-line in source view.

Remove the empty anchor element and add the line ID (Lnnn)
to the span element that contains the line number.
Fixes issue 5903.
Fixes issue 5977.

R=adg
CC=bradfitz, golang-dev
https://codereview.appspot.com/12189043

Committer: Andrew Gerrand <adg@golang.org>

Expand All Messages | Collapse All Messages