Issue 1215041: Fix Refresh override

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1215041: Fix Refresh override

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 11 months ago by zhoresh

Modified:
13 years, 11 months ago

Reviewers:
johnfargo, Paul Lindner, shindig.remailer

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk

Visibility:
Public.

Description

Fix handling of refresh time by ProxyHandler. The handler class already handle the refresh so skip the refresh update in the proxy base. The real problem was that chain param style proxy refresh would be ignored and replaced with the default.

Patch Set 1 #

Created: 13 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
		java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyBase.java	View		1 chunk	+5 lines, -0 lines	0 comments	Download
		java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

zhoresh

13 years, 11 months ago (2010-05-14 20:31:44 UTC) #3

On 2010/05/14 01:05:51, Paul Lindner wrote:
> lgtm

Thanks! committed as r944443

Expand All Messages | Collapse All Messages