Issue 12148043: Add SCSS support

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12148043: Add SCSS support (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by huwshimi

Modified:
10 years, 9 months ago

Reviewers:
mp+177744

Visibility:
Public.

Description

Add SCSS support Added SCSS building to the template builders. At the moment we're building LESS and SCSS but we can remove LESS once the CSS files have been migrated over. I've added a new folder in the standard assets folder, all CSS wil eventually be migrated to the new folder. Anything in the new directory will be built using SCSS. I ended up use the node-sass model instead of pysass as our build setup is designed to use Node models already. If anyone has an issue we could add additional build steps to replace this in Python. https://code.launchpad.net/~huwshimi/juju-gui/add-scss/+merge/177744 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Add SCSS support #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+61 lines, -4 lines)			Patch
M	Makefile	View	1 chunk	+2 lines, -1 line	0 comments	Download
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	app/assets/css/base.scss	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	config.js	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	lib/templates.js	View	4 chunks	+24 lines, -3 lines	0 comments	Download
M	npm-shrinkwrap.json	View	1 chunk	+27 lines, -0 lines	0 comments	Download
M	package.json	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

huwshimi

10 years, 9 months ago (2013-08-01 00:26:57 UTC) #2

*** Submitted:

Add SCSS support

Added SCSS building to the template builders.

At the moment we're building LESS and SCSS but we can remove LESS once the CSS
files have been migrated over.

I've added a new folder in the standard assets folder, all CSS wil eventually be
migrated to the new folder. Anything in the new directory will be built using
SCSS.

I ended up use the node-sass model instead of pysass as our build setup is
designed to use Node models already. If anyone has an issue we could add
additional build steps to replace this in Python.

R=
CC=
https://codereview.appspot.com/12148043

Expand All Messages | Collapse All Messages