Issue 12141043: code review 12141043: fmt: put a ! in all error output generated by Printf-li...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12141043: code review 12141043: fmt: put a ! in all error output generated by Printf-li... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by r

Modified:
11 years, 11 months ago

Reviewers:
dsymonds, kisielk

CC:
golang-dev, dsymonds

Visibility:
Public.

Description

fmt: put a ! in all error output generated by Printf-like functions Fixes issue 5730.

Patch Set 1 #

Total comments: 2

Patch Set 2 : diff -r 6ee94a5c6e42 https://code.google.com/p/go/ #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -20 lines)			Patch
M	src/pkg/fmt/doc.go	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/fmt/fmt_test.go	View	2 chunks	+15 lines, -15 lines	0 comments	Download
M	src/pkg/fmt/print.go	View	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

11 years, 11 months ago (2013-07-31 03:55:20 UTC) #1

*** Submitted as https://code.google.com/p/go/source/detail?r=9873560af4bd *** fmt: put a ! in all error output generated by ...

11 years, 11 months ago (2013-07-31 04:08:53 UTC) #3

kisielk

11 years, 11 months ago (2013-07-31 04:27:32 UTC) #4

Message was sent while issue was closed.

Doesn't seem quite right, unless I'm missing something?

https://codereview.appspot.com/12141043/diff/1/src/pkg/fmt/doc.go
File src/pkg/fmt/doc.go (right):

https://codereview.appspot.com/12141043/diff/1/src/pkg/fmt/doc.go#newcode162
src/pkg/fmt/doc.go:162: All errors begin with the string "%!" followed sometimes
This claims all errors start with %!, but the ones in this CL are %d!

https://codereview.appspot.com/12141043/diff/1/src/pkg/fmt/doc.go#newcode172
src/pkg/fmt/doc.go:172: %s(PANIC=bad)
Should this have a ! as well?

Expand All Messages | Collapse All Messages