Issue 121400043: code review 121400043: cmd/go: don't pass --buildid=none on FreeBSD

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 121400043: code review 121400043: cmd/go: don't pass --buildid=none on FreeBSD (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by iant

Modified:
10 years, 9 months ago

Reviewers:
dave

CC:
bradfitz, golang-codereviews

Visibility:
Public.

Description

cmd/go: don't pass --buildid=none on FreeBSD According to the FreeBSD builder, it doesn't work.

Patch Set 1 #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/cmd/go/build.go	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

iant

Hello bradfitz (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

10 years, 9 months ago (2014-08-07 20:51:27 UTC) #1

iant

*** Submitted as https://code.google.com/p/go/source/detail?r=1465e952f36a *** cmd/go: don't pass --buildid=none on FreeBSD According to the FreeBSD ...

10 years, 9 months ago (2014-08-07 20:51:36 UTC) #2

dave_cheney.net

10 years, 9 months ago (2014-08-07 20:53:15 UTC) #3

LGTM. Worth a shot
On 8 Aug 2014 06:51, <iant@golang.org> wrote:

> *** Submitted as
> https://code.google.com/p/go/source/detail?r=1465e952f36a ***
>
> cmd/go: don't pass --buildid=none on FreeBSD
>
> According to the FreeBSD builder, it doesn't work.
>
> TBR=bradfitz
> CC=golang-codereviews
> https://codereview.appspot.com/121400043
>
>
> https://codereview.appspot.com/121400043/
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

Expand All Messages | Collapse All Messages