Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(92)

Issue 12111043: Notification mail template (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by ana.balica
Modified:
10 years, 8 months ago
Reviewers:
thomas.j.waldmann, waldi
Visibility:
Public.

Description

This it the notification mail template, that extends the base mail template and uses 2 macros for rendering content and meta diff.

Patch Set 1 #

Total comments: 4

Patch Set 2 : Minor fixes #

Total comments: 2

Patch Set 3 : Use relative measurements #

Patch Set 4 : Set wiki name in the footer #

Patch Set 5 : Remove the duplication of "you are subscribed" info #

Patch Set 6 : Add comment section #

Patch Set 7 : Add item url #

Patch Set 8 : Remove `wiki category` text in the footer #

Patch Set 9 : Replace `page` with `item` #

Patch Set 10 : Use a more appropriate variable name for diff url #

Patch Set 11 : Use an entire sentence #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -0 lines) Patch
A MoinMoin/templates/mail/notification_main.html View 1 2 3 4 5 6 7 8 9 10 1 chunk +46 lines, -0 lines 0 comments Download

Messages

Total messages: 4
ana.balica
https://codereview.appspot.com/12111043/diff/1/MoinMoin/templates/mail/notification_main.html File MoinMoin/templates/mail/notification_main.html (right): https://codereview.appspot.com/12111043/diff/1/MoinMoin/templates/mail/notification_main.html#newcode1 MoinMoin/templates/mail/notification_main.html:1: {% extends theme("mail/html_base.html") %} The html_base.html template is here ...
10 years, 9 months ago (2013-07-30 15:50:35 UTC) #1
waldi
https://codereview.appspot.com/12111043/diff/1/MoinMoin/templates/mail/notification_main.html File MoinMoin/templates/mail/notification_main.html (right): https://codereview.appspot.com/12111043/diff/1/MoinMoin/templates/mail/notification_main.html#newcode8 MoinMoin/templates/mail/notification_main.html:8: <div style="font-size:14px;"> No absolute sizes.
10 years, 9 months ago (2013-07-31 14:55:54 UTC) #2
Thomas.J.Waldmann
https://codereview.appspot.com/12111043/diff/5001/MoinMoin/templates/mail/notification_main.html File MoinMoin/templates/mail/notification_main.html (right): https://codereview.appspot.com/12111043/diff/5001/MoinMoin/templates/mail/notification_main.html#newcode30 MoinMoin/templates/mail/notification_main.html:30: <div style="font-size:0.7em; margin-top:25px;"> still px in usage. think of ...
10 years, 9 months ago (2013-08-11 11:19:16 UTC) #3
ana.balica
10 years, 9 months ago (2013-08-12 09:45:04 UTC) #4
https://codereview.appspot.com/12111043/diff/5001/MoinMoin/templates/mail/not...
File MoinMoin/templates/mail/notification_main.html (right):

https://codereview.appspot.com/12111043/diff/5001/MoinMoin/templates/mail/not...
MoinMoin/templates/mail/notification_main.html:30: <div style="font-size:0.7em;
margin-top:25px;">
On 2013/08/11 11:19:16, Thomas.J.Waldmann wrote:
> still px in usage.
> 
> think of "retina" displays.

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b