Fixes #1202636 use pretty names for providers.

Fixes #1202636 use pretty names for providers.

- The test data we import is run on HP cloud but named 'openstack'.
- We use the filter UI rules for translating the 'id' of a provider to a
pretty name.
- Those are updated so that an id of openstack will output HP Cloud since
that's what it actually is in testing.
- A work item has been brought up with the charmers team to correct the naming
to be 100% specific and updates will be coordinated at a later time.
- This means there are three tests and only three providers to display in the
gui: ec2, local, hp
- We add a template helper so that we can share the mapping of id -> pretty
name across all of the UI from filters through to the charm details page.

https://code.launchpad.net/~rharding/juju-gui/hp-only/+merge/177585

(do not edit description out of merge proposal)

[rharding, 2013-07-30 12:54:22]

Please take a look.

[bac, 2013-07-30 13:01:03]

LGTM.  Thanks Rick.  I did not QA this change.

[gary.poster, 2013-07-30 13:32:54]

Hey Rick.  Thank you for doing this.  QA is bad though: links don't work.

Here's one direction that I sketched to see if it would work.  feel free to use
or discard.

=== modified file 'app/models/charm.js'                                        
--- app/models/charm.js	2013-07-30 12:37:21 +0000
+++ app/models/charm.js	2013-07-30 13:30:14 +0000
@@ -574,31 +574,25 @@
       'providers': {
         /**
          * @method providers.valueFn
-         * @return {Array} the list of failing provider names.
+         * @return {Array} the list of failing provider keys and names.
          *
          */
         valueFn: function() {
           var failures = [],
               successes = [],
-              providers = this.get('tested_providers');
+              providers = this.get('tested_providers'),
+              // Set up a map for converting provider keys to presentation
+              // names.
+              // The HP test is currently called openstack in the test data we
+              // import.
+              names = {'openstack': 'HP Cloud'};
           Y.Object.each(providers, function(value, key) {
+            var data = {key: key, name: names[key] || key};
             if (value !== 'SUCCESS') {
-              // The HP test is currently called openstack in the test data we
-              // import. Adjust the name for UX.
-              if (key === 'openstack') {
-                failures.push('hp');
-              } else {
-                failures.push(key);
-              }
+              failures.push(data);
             }
             else {
-              // The HP test is currently called openstack in the test data we
-              // import. Adjust the name for UX.
-              if (key === 'openstack') {
-                successes.push('hp');
-              } else {
-                successes.push(key);
-              }
+              successes.push(data);
             }
           });
 

=== modified file 'app/templates/providers.partial'
--- app/templates/providers.partial     2013-07-17 18:27:38 +0000              
+++ app/templates/providers.partial	2013-07-30 13:19:01 +0000
@@ -6,8 +6,8 @@
                 {{#providers.successes}}
                     <li>
                         <i class="sprite provider_success"></i>
-                        <a
href="https://jenkins.qa.ubuntu.com/job/{{../../series}}-{{.}}-charm-{{../../name}}/lastBuild"
-                        target="help">{{.}}</a>
+                        <a
href="https://jenkins.qa.ubuntu.com/job/{{../../series}}-{{key}}-charm-{{../../name}}/lastBuild"
+                        target="help">{{name}}</a>
                     </li>
                 {{/providers.successes}}
             </ul>
@@ -17,8 +17,8 @@
                 {{#providers.failures}}
                     <li>
                         <i class="sprite provider_failure"></i>
-                        <a
href="https://jenkins.qa.ubuntu.com/job/{{../../series}}-{{.}}-charm-{{../../name}}/lastBuild"
-                        target="help">{{.}}</a>
+                        <a
href="https://jenkins.qa.ubuntu.com/job/{{../../series}}-{{key}}-charm-{{../../name}}/lastBuild"
+                        target="help">{{name}}</a>
                     </li>
                 {{/providers.failures}}
             </ul>

https://codereview.appspot.com/12102043/diff/1/app/models/charm.js
File app/models/charm.js (right):

https://codereview.appspot.com/12102043/diff/1/app/models/charm.js#newcode584
app/models/charm.js:584: Y.Object.each(providers, function(value, key) {
I suggest collapsing the name logic here.

var data = {key: key, name: key};
if (key === 'openstack') {
  // The HP test is currently called openstack in the test data we
  // import. Adjust the name for UX.
  data.name = 'HP Cloud';
}

or similar.

Note that I also suggest that we use "HP Cloud;" this change is also in part to
get the attention of partners, and spelling their product fully is a good idea,
and what Antonio wants, I think.

Also, note that I am keeping the key around.  I will report "QA bad" in the main
review: we need to distinguish these because the links are breaking.

https://codereview.appspot.com/12102043/diff/1/app/models/charm.js#newcode585
app/models/charm.js:585: if (value !== 'SUCCESS') {
If you agree with my suggestion, then this block (below) would simply be

  failures.push(data);

https://codereview.appspot.com/12102043/diff/1/app/models/charm.js#newcode594
app/models/charm.js:594: else {
If you agree with my suggestion, then this block (below) would simply be

  successes.push(data);

[rharding, 2013-07-30 14:14:34]

Please take a look.

[jeff.pihach, 2013-07-30 14:40:15]

LGTM 

QA is good - links show up with proper names and are clickable.

[bac, 2013-07-30 14:46:47]

LGTM -- I like this new approach

https://codereview.appspot.com/12102043/diff/7001/app/models/browser.js
File app/models/browser.js (right):

https://codereview.appspot.com/12102043/diff/7001/app/models/browser.js#newco...
app/models/browser.js:79: if (id === 'local') {
Since these are exclusive I think it would read better with an 'else' here.

[rharding, 2013-07-30 14:56:54]

*** Submitted:

Fixes #1202636 use pretty names for providers.

- The test data we import is run on HP cloud but named 'openstack'.
- We use the filter UI rules for translating the 'id' of a provider to a
pretty name.
- Those are updated so that an id of openstack will output HP Cloud since
that's what it actually is in testing.
- A work item has been brought up with the charmers team to correct the naming
to be 100% specific and updates will be coordinated at a later time.
- This means there are three tests and only three providers to display in the
gui: ec2, local, hp
- We add a template helper so that we can share the mapping of id -> pretty
name across all of the UI from filters through to the charm details page.

R=bac, gary.poster, jeff.pihach
CC=
https://codereview.appspot.com/12102043