Issue 12100043: code review 12100043: freetype/truetype: add explicit graphics state.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12100043: code review 12100043: freetype/truetype: add explicit graphics state. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by nigeltao

Modified:
11 years, 3 months ago

Reviewers:
bsiegert

CC:
bsiegert, golang-dev

Visibility:
Public.

Description

freetype/truetype: add explicit graphics state. These new opcodes aren't unit-tested per se, but they will be exercised by an end-to-end hinting test of the Luxi fonts.

Patch Set 2 : diff -r 50ad5fe0a301 https://code.google.com/p/freetype-go #

Patch Set 3 : diff -r 50ad5fe0a301 https://code.google.com/p/freetype-go #

Total comments: 1

Patch Set 4 : diff -r 50ad5fe0a301 https://code.google.com/p/freetype-go #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+198 lines, -100 lines)			Patch
M	freetype/truetype/glyph.go	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	freetype/truetype/hint.go	View	1 2 3	11 chunks	+172 lines, -75 lines	0 comments	Download
M	freetype/truetype/opcodes.go	View	1	5 chunks	+23 lines, -23 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nigeltao

Hello bsiegert@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/freetype-go

11 years, 3 months ago (2013-07-30 12:15:48 UTC) #1

bsiegert

LGTM https://codereview.appspot.com/12100043/diff/5001/freetype/truetype/hint.go File freetype/truetype/hint.go (left): https://codereview.appspot.com/12100043/diff/5001/freetype/truetype/hint.go#oldcode132 freetype/truetype/hint.go:132: // TODO: h.dv = h.pv ?? s/h/h.gs/ similarly ...

11 years, 3 months ago (2013-07-30 13:43:50 UTC) #2

nigeltao

11 years, 3 months ago (2013-08-02 09:13:45 UTC) #3

*** Submitted as
https://code.google.com/p/freetype-go/source/detail?r=eaf11fb9761a ***

freetype/truetype: add explicit graphics state.

These new opcodes aren't unit-tested per se, but they will be
exercised by an end-to-end hinting test of the Luxi fonts.

R=bsiegert
CC=golang-dev
https://codereview.appspot.com/12100043

Expand All Messages | Collapse All Messages