state: unexport ParseTag

state: unexport ParseTag

...which should clearly never have been exported in the first place.

https://code.launchpad.net/~fwereade/juju-core/state-unexport-parse-tag/+merge/177557

(do not edit description out of merge proposal)

[fwereade, 2013-07-30 10:31:11]

Please take a look.

[rog, 2013-07-30 13:58:13]

LGTM with one thought.

https://codereview.appspot.com/12097043/diff/1/state/export_test.go
File state/export_test.go (right):

https://codereview.appspot.com/12097043/diff/1/state/export_test.go#newcode183
state/export_test.go:183: func ParseTag(st *State, tag string) (string, string,
error) {
or:

func (st *State) ParseTag(tag string) (string, string, error) {
   return st.parseTag(tag)
}

then the tests won't need to change.
i don't mind either way, just a possibility you might not have considered.

[fwereade, 2013-07-30 16:13:04]

On 2013/07/30 13:58:13, rog wrote:
> LGTM with one thought.
> 
> https://codereview.appspot.com/12097043/diff/1/state/export_test.go
> File state/export_test.go (right):
> 
> https://codereview.appspot.com/12097043/diff/1/state/export_test.go#newcode183
> state/export_test.go:183: func ParseTag(st *State, tag string) (string,
string,
> error) {
> or:
> 
> func (st *State) ParseTag(tag string) (string, string, error) {
>    return st.parseTag(tag)
> }
> 
> then the tests won't need to change.
> i don't mind either way, just a possibility you might not have considered.

Oddly enough, I did try it; I got weird linker errors, resolved not to care too
much, and did this instead.