code review 12091043: net: fix comment on SetKeepAlivePeriod

net: fix comment on SetKeepAlivePeriod

[mikio, 2013-07-30 05:50:17]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[dave_cheney.net, 2013-07-30 06:24:23]

Please fix the issue description to say

net: fix comment on SetKeepAlivePeriod.

// SetKeepAlivePeriod sets the period between keep-alive messages.

On Tue, Jul 30, 2013 at 3:50 PM,  <mikioh.mikioh@gmail.com> wrote:
> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> net: fix document on SetKeepAlivePeriod
>
> Please review this at https://codereview.appspot.com/12091043/
>
> Affected files:
>   M src/pkg/net/tcpsock_posix.go
>
>
> Index: src/pkg/net/tcpsock_posix.go
> ===================================================================
> --- a/src/pkg/net/tcpsock_posix.go
> +++ b/src/pkg/net/tcpsock_posix.go
> @@ -121,7 +121,7 @@
>         return setKeepAlive(c.fd, keepalive)
>  }
>
> -// SetKeepAliveIdlePeriod sets period between keep alives.
> +// SetKeepAlivePeriod sets period between keep alives.
>  func (c *TCPConn) SetKeepAlivePeriod(d time.Duration) error {
>         if !c.ok() {
>                 return syscall.EINVAL
>
>
> --
>
> ---You received this message because you are subscribed to the Google Groups
> "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>

[mikio, 2013-07-30 06:40:49]

Hello golang-dev@googlegroups.com, dave@cheney.net (cc:
golang-dev@googlegroups.com),

Please take another look.

[dave_cheney.net, 2013-07-30 06:42:22]

LGTM. Thank you.

[mikio, 2013-07-30 07:32:04]

*** Submitted as https://code.google.com/p/go/source/detail?r=42ec35f8b19c ***

net: fix comment on SetKeepAlivePeriod

R=golang-dev, dave
CC=golang-dev
https://codereview.appspot.com/12091043