Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(864)

Issue 1208041: [SOC-828] Database configuration should not use macros/variables

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 11 months ago by hoatle
Modified:
9 years, 4 months ago
Reviewers:
exo-sc
CC:
hanhvq_gmail.com, nghia910_gmail.com
Base URL:
http://svn.exoplatform.org/projects/social/branches/1.0.x
Visibility:
Public.

Description

Configuring the database for /socialdemo involves editing gatein/conf/configuration.properties file. The database shcemas are cofigured with an ${name} macro which is not explicitely defined elsewhere. So this is error prone and dangerous. We should have a mean to hard-conffigure the database for the socialdemo portal. Example of problematic configuration : \# JCR gatein.jcr.datasource.url=jdbc:hsqldb:file:${gatein.db.data.dir}/data/jdbcjcr_${name} \# IDM gatein.idm.datasource.url=jdbc:hsqldb:file:${gatein.db.data.dir}/data/jdbcidm_${name}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
server/tomcat/patch/src/main/tomcat/gatein/conf/configuration.properties View 1 chunk +3 lines, -0 lines 0 comments Download
server/tomcat/patch/src/main/tomcat/gatein/conf/portal/socialdemo/socialdemo.properties View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 1
hoatle
13 years, 11 months ago (2010-05-13 18:45:15 UTC) #1

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b