Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(114)

Issue 120760043: code review 120760043: cmd/ld: remove duplicated nuxiinit() call. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by minux
Modified:
10 years, 10 months ago
Reviewers:
dave
CC:
rsc, dave_cheney.net, golang-codereviews
Visibility:
Public.

Description

cmd/ld: remove duplicated nuxiinit() call. It is already called by linknew().

Patch Set 1 #

Patch Set 2 : diff -r 6f0ff681e5ea https://code.google.com/p/go #

Patch Set 3 : diff -r 6f0ff681e5ea https://code.google.com/p/go #

Patch Set 4 : diff -r faac714bfb95 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M src/cmd/ld/pobj.c View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3
minux
Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
10 years, 10 months ago (2014-07-26 08:02:35 UTC) #1
dave_cheney.net
LGTM. On Sat, Jul 26, 2014 at 6:02 PM, <minux@golang.org> wrote: > Reviewers: rsc, > ...
10 years, 10 months ago (2014-07-26 11:03:42 UTC) #2
minux
10 years, 10 months ago (2014-07-26 21:45:48 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=d36000ed8655 ***

cmd/ld: remove duplicated nuxiinit() call.

It is already called by linknew().

LGTM=dave
R=rsc, dave
CC=golang-codereviews
https://codereview.appspot.com/120760043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b