Issue 12072043: code review 12072043: go/parser: don't report name errors if DeclarationError...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12072043: code review 12072043: go/parser: don't report name errors if DeclarationError... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by gri

Modified:
12 years, 4 months ago

Reviewers:
adonovan

CC:
adonovan, golang-dev

Visibility:
Public.

Description

go/parser: don't report name errors if DeclarationErrors is not set

Patch Set 1 #

Patch Set 2 : diff -r 2a5736615a86 https://code.google.com/p/go #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/pkg/go/parser/parser.go	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello adonovan (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

12 years, 4 months ago (2013-07-29 22:51:00 UTC) #1

adonovan

On 2013/07/29 22:51:00, gri wrote: > Hello adonovan (cc: mailto:golang-dev@googlegroups.com), > > I'd like you ...

12 years, 4 months ago (2013-07-29 22:56:38 UTC) #2

gri

12 years, 4 months ago (2013-07-29 23:00:36 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=28804633ed71 ***

go/parser: don't report name errors if DeclarationErrors is not set

R=adonovan
CC=golang-dev
https://codereview.appspot.com/12072043

Expand All Messages | Collapse All Messages