Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(255)

Issue 12071043: Remove additional buttons on ghost insp.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by jeff.pihach
Modified:
10 years, 8 months ago
Reviewers:
rharding, mp+177488, matthew.scott
Visibility:
Public.

Description

Remove additional buttons on ghost insp. Removes the additional buttons on the ghost inspector that was caused by sharing the same template for the ghost and service inspector configuration. The UI's differ between these two inspectors, the ghost has the confirm/cancel buttons fixed to the bottom of the inspector where the service inspector has it fixed to the bottom of the settings list. Maybe design will normalize these later? https://code.launchpad.net/~hatch/juju-gui/remove-extra-buttons/+merge/177488 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Remove additional buttons on ghost insp. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -42 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M app/templates/ghost-config-wrapper.handlebars View 1 chunk +7 lines, -4 lines 0 comments Download
M app/templates/service-configuration.partial View 2 chunks +2 lines, -0 lines 0 comments Download
M app/views/environment.js View 1 chunk +1 line, -1 line 0 comments Download
M app/views/inspector.js View 1 chunk +3 lines, -0 lines 0 comments Download
M lib/views/juju-inspector.less View 3 chunks +27 lines, -37 lines 0 comments Download

Messages

Total messages: 5
jeff.pihach
Please take a look.
10 years, 8 months ago (2013-07-29 22:28:36 UTC) #1
rharding
code looks ok. Will QA
10 years, 8 months ago (2013-07-30 14:28:58 UTC) #2
rharding
LGTM qa's ok. Hitting cancel though leaves an service icon on the canvas when I'd ...
10 years, 8 months ago (2013-07-30 14:36:12 UTC) #3
matthew.scott
LGTM, thanks!
10 years, 8 months ago (2013-07-30 15:50:29 UTC) #4
jeff.pihach
10 years, 8 months ago (2013-07-30 16:08:17 UTC) #5
*** Submitted:

Remove additional buttons on ghost insp.

Removes the additional buttons on the ghost inspector that
was caused by sharing the same template for the ghost and
service inspector configuration. The UI's differ between
these two inspectors, the ghost has the confirm/cancel buttons
fixed to the bottom of the inspector where the service 
inspector has it fixed to the bottom of the settings list.
Maybe design will normalize these later?

R=rharding, matthew.scott
CC=
https://codereview.appspot.com/12071043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b