code review 120630043: undo CL 114420043 / b613f2acdf69

undo CL 114420043 / b613f2acdf69

Broke freebsd/amd64 due to exposure of a latent bug.

««« original CL description
cmd/ld: fix operator precedence

LGTM=rsc
R=rsc, iant
CC=golang-codereviews
https://codereview.appspot.com/114420043
»»»

[minux, 2014-08-06 06:07:19]

Hello dave@cheney.net (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[minux, 2014-08-06 06:07:34]

*** Submitted as https://code.google.com/p/go/source/detail?r=2d368630a66e ***

undo CL 114420043 / b613f2acdf69

Broke freebsd/amd64 due to exposure of a latent bug.

««« original CL description
cmd/ld: fix operator precedence

LGTM=rsc
R=rsc, iant
CC=golang-codereviews
https://codereview.appspot.com/114420043
»»»

TBR=dfc
R=dave
CC=golang-codereviews
https://codereview.appspot.com/120630043

[dave_cheney.net, 2014-08-06 06:08:39]

LGTM. Thank you.

If it is not too late, would you please open an issue to track this.

On Wed, Aug 6, 2014 at 4:07 PM,  <minux@golang.org> wrote:
> *** Submitted as
> https://code.google.com/p/go/source/detail?r=2d368630a66e ***
>
>
> undo CL 114420043 / b613f2acdf69
>
> Broke freebsd/amd64 due to exposure of a latent bug.
>
> ««« original CL description
> cmd/ld: fix operator precedence
>
> LGTM=rsc
> R=rsc, iant
> CC=golang-codereviews
> https://codereview.appspot.com/114420043
> »»»
>
> TBR=dfc
> R=dave
> CC=golang-codereviews
> https://codereview.appspot.com/120630043
>
>
> https://codereview.appspot.com/120630043/

[minux, 2014-08-06 06:14:40]

On Wed, Aug 6, 2014 at 2:08 AM, Dave Cheney <dave@cheney.net> wrote:

> LGTM. Thank you.
>
> If it is not too late, would you please open an issue to track this.

filed issue 8480.

[gobot, 2014-08-06 06:25:37]

This CL appears to have broken the darwin-amd64-cheney builder.
See http://build.golang.org/log/8fc996c39a589f52bcfbed0b65912a12d0c63239

[dave_cheney.net, 2014-08-06 06:26:06]

nope.

 --- FAIL: TestShutdown (56.62s)

net_test.go:57: client Read: 0, read tcp 127.0.0.1:58404: operation timed out
FAIL
FAIL net 59.217s

On Wed, Aug 6, 2014 at 4:25 PM,  <gobot@golang.org> wrote:
> This CL appears to have broken the darwin-amd64-cheney builder.
> See http://build.golang.org/log/8fc996c39a589f52bcfbed0b65912a12d0c63239
>
> https://codereview.appspot.com/120630043/